Repository navigation
fix(ble): only report disconnects the device starts as unexpected - #349
Merged
Merged
Conversation
BLEConnection logged "Unexpected disconnect" for every disconnect it started itself (the idle timer after each command, disconnectAll, a failed connection), because nothing marked them as expected. Meanwhile a disconnect started by the device (out of range, powered off) was never noticed: the dead peripheral stayed in the connection map and the next command reused it. - disconnect() is always intentional: it logs at debug level. - A 'disconnect' listener on the peripheral drops the connection state (characteristics, encryption, pending reply) and warns only when the device dropped the link; markExpectedDisconnect() silences that warning. - The characteristic-discovery failure path uses disconnect(). Supersedes #348. Co-authored-by: dnicolson <dnicolson@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TYWa2RXoWsaUTWh76oNv8s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Since 5.x, every BLE command is followed a few seconds later by
[BLEConnection] WARN: Unexpected disconnect from …(reported in #348).disconnect()warned unless the MAC had been passed tomarkExpectedDisconnect(), and nothing in the library ever called that. So the idle auto-disconnect after each command,disconnectAll(), and cleanup after a failed connection all warned.The opposite case was not handled at all. When the device drops the link (out of range, powered off, rebooted), the dead peripheral stayed in
connections, andconnect()returned "already connected". The next command was then written over a dead link.Changes (
src/ble.ts)disconnect()is always started by us, so it logs at debug level. Calling it for a device that isn't connected is no longer a warning.connect()attaches adisconnectlistener to the peripheral. If the device drops the link, the listener:Unexpected disconnect;markExpectedDisconnect()now means "the device is about to drop the link, e.g. after a restart command; don't warn".disconnect().Why
This supersedes #348 by @dnicolson, which marked the idle and
disconnectAllpaths as expected. That fixed the warning but still logged at info level on every command, and left the dead-link case unhandled. @dnicolson is credited as co-author.Tests
test/apis/ble-disconnect.test.tscovers:connect()reconnects;408 tests pass. Build and lint pass.
No breaking changes. I'll carry this into
beta-6.0.0after merge.Generated by Claude Code