Skip to content

Improve failure logging #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
donavanbecker merged 2 commits into from
Oct 25, 2026
Merged

Improve failure logging #351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96bac1c
Improve failure logging
dnicolson Oct 24, 2026
6aa3b64
Merge branch 'latest' into patch-2
donavanbecker Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/devices/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,10 @@ export abstract class SwitchBotDevice extends EventEmitter {
try {
return await tryBLE()
} catch (err) {
this.logger?.warn?.('BLE getStatus failed, falling back to API', err)
this.logger?.warn?.('BLE getStatus failed', err)
if (this.enableFallback && this.hasAPI()) {
this.logger?.warn?.('Falling back to API getStatus', err)
}
}
if (this.enableFallback && this.hasAPI()) {
return await tryAPI()
Expand All @@ -357,7 +360,10 @@ export abstract class SwitchBotDevice extends EventEmitter {
try {
return await tryAPI()
} catch (err) {
this.logger?.warn?.('API getStatus failed, falling back to BLE', err)
this.logger?.warn?.('API getStatus failed', err)
if (this.enableFallback && this.hasBLE()) {
this.logger?.warn?.('Falling back to BLE getStatus', err)
}
}
if (this.enableFallback && this.hasBLE()) {
return await tryBLE()
Expand Down
Loading