Repository navigation
docs: fix Hardhat upgrades require destructuring braces - #261
Closed
ninglinLiu wants to merge 1 commit into
Closed
ninglinLiu wants to merge 1 commit into
ninglinLiu wants to merge 1 commit into
Conversation
Several Hardhat 2 / legacy upgradeable examples used invalid syntax
`const ethers, upgrades = require("hardhat")` instead of
`const { ethers, upgrades } = require("hardhat")`.
Related: OpenZeppelin/docs.openzeppelin.com#457
✅ Deploy Preview for openzeppelin-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several Hardhat 2 / legacy upgradeable examples used invalid JavaScript:
instead of:
Fixed in:
content/upgrades-plugins/hardhat-2/hardhat-upgrades.mdxcontent/upgrades-plugins/hardhat-2/api-hardhat-upgrades.mdxcontent/upgrades-plugins/migrate-from-cli.mdxcontent/contracts/3.x/upgradeable.mdxcontent/contracts/4.x/upgradeable.mdxRelated issue on the legacy site tracker: OpenZeppelin/docs.openzeppelin.com#457
This PR was prepared with AI assistance and reviewed/tested by the author.