Repository navigation
Conversation
Owner
Author
|
CI note: Go and Node 20/22 checks pass. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codeagent-wrapperbackend using a local JSONL RPC subprocess (--mode rpc), with model selection, CLI parsing, workflow injection, doctor checks, and role prompt installation.errorMessagefield), malformed streams, and premature EOF; never silently fall back to another model.OpenSlime manages the local Pi subprocess. Pi continues to own provider credentials, model capabilities, context-window configuration, and thinking levels; this PR does not add a standalone remote Pi server transport.
Validation
pnpm typecheckpnpm test— 38 files, 457 tests passedpnpm buildpnpm pack --pack-destination /tmp --json— all 8 Pi role templates includedenv -u PI_MODEL go test -short ./... -count=1env -u PI_MODEL go test -race ./... -run 'Pi' -count=1env -u PI_MODEL go vet ./...@/shell-character input preserved; resume retained the same session ID and recalled its marker; assistant ran athighthinking with nonzero reasoning tokens.Existing unrelated test issue
The non-short
env -u PI_MODEL go test ./... -count=1run reproduces two timing-sensitive Codex test failures:TestRunCodexTask_ForcesStopAfterCompletionTestRunCodexTask_DoesNotTerminateBeforeThreadCompletedBoth fail identically on the unmodified
mainbaseline (e99bd5b), so this PR leaves the unrelated generic Codex behavior unchanged. The CI-equivalent short suite and all Pi checks pass.