Remove 'borough', 'macroregion', and 'macrocountry' from the subtype enum - #413
Remove 'borough', 'macroregion', and 'macrocountry' from the subtype enum#413Mart van de Ven (tijptjik) wants to merge 0 commit into
Conversation
|
Stephen Epps (@stepps00) Could you take a look at this one? |
|
I'd be inclined to keep the schema as-is, as Overture may still maintain features at these subtypes in future releases. Each are valid representations of administrative divisions, removing them would leave gaps in the subtype hierarchy. That being said, some work could be done to simplify the subtype definitions.. but I think that work would reclassify, rather than remove subtypes. Saša Stanojkov (@sasastanojkov) thoughts? |
FWIW -- borough and other valid administrative divisions still show up in the |
|
This would likely be superseded by work in #414 |
I personally am ok either way. If we strictly look at what we currently have in the data, I am ok with removing these subtypes. |
|
In the 2026-04-29 schema WG weekly meeting, Stephen Epps (@stepps00) took the action to raise this question in the divisions TF and decide whether to move forward with it (would require Pydantic update) or close it. |
|
cc Pradeep Kumar (@pradeepbkkumar) - we discussed this open pull request yesterday. We agreed that the borough subtype will be needed for upcoming releases, and it sounded like some work was needed from your end to understand per-country requirements for the other two subtypes. Let's review those macroregion and macrocounty requirements over the next ~two weeks. If we don't see the need to support those in the schema, we can drop them (though retain borough). |
8e07ee3 to
49b789e
Compare
❌ PR Title Validation FailedError: No release type found in pull request title "Remove 'borough', 'macroregion', and 'macrocountry' from the subtype enum". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/ Available types:
Examples:
See the Overture Maps Foundation GitHub usage guidelines for full documentation. |
❌ Linked Issue Check FailedThis PR does not reference enough linked issues (found 0, required 1). Please link an issue from this repository, using After adding a linked issue, you may need to manually re-run this check from the Checks tab to update the status. |


Description
It appears that
borough,macroregion, andmacrocountryare no longer valid enum values, as they are no longer in use as of the latest release2025-10-22.0, and the Overture Docs also don't make mention of them anymore.However the schema still had them listed as valid enum values. This PR removed them from the schema.
Reference
Testing
result:
For example, looking up the

subtypeof "The Bronx", which previously was a "borough" and is now a "macrohood"Checklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation website
Update the hyperlink below to put the pull request number in.
[Docs preview for this PR.](https://dfhx9f55j8eg5.cloudfront.net/pr/<PUT THE PR # HERE>)