[CHORE](ci) Skip changelog fragment check for bot-labeled PRs - #645
Merged
Conversation
Dependabot PRs fail this check because dependency bumps don't carry a changelog.d/ fragment, and shouldn't need one. Dependabot already applies the bot label on both the github-actions and uv update configs in .github/dependabot.yml, so gating the job on that label needs no dependabot.yml changes. Fixes #644 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
John McCall (lowlydba)
added
the
automation 🦾
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
check-fragment now skips for bot-labeled PRs, so branch protection can't require it directly (a job that sometimes doesn't run can't be a required check). Add changelog-fragment-status as a final gate using lowlydba/are-we-good, which always runs and passes on either a real success or an accepted skip. Require that job in branch protection instead of check-fragment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the changelog-fragment enforcement workflow so automation PRs (e.g., Dependabot) can merge without needing a changelog.d/ fragment, while still providing a consistently-present status check suitable for branch protection rules.
Changes:
- Skips the
check-fragmentjob when the PR has thebotlabel. - Adds an always-running
changelog-fragment-statusgate job that aggregates thecheck-fragmentoutcome (including accepted skips) vialowlydba/are-we-good.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add detect-scope, using tj-actions/changed-files (already the repo's convention in detect-affected-packages) to report whether anything outside .github/ changed. check-fragment now skips when it hasn't, same as the bot-label skip, since workflow and CI config aren't packages. changelog-fragment-status rolls detect-scope in too, so a detect-scope failure surfaces instead of reading as an accepted skip. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Switch detect-scope from an ignore-list (.github/**) to an allow-list (packages/**): check-fragment only ever inspects packages/<package>/ paths, so anything that doesn't touch packages/ -- docs, root-level files, CI config -- never needed a fragment. This covers docs-only and root-only PRs the same way it already covered .github-only ones, without another ignore entry per new top-level directory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Seth Fitzsimmons (sethfitz)
approved these changes
Aug 6, 2026
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
Eric Godwin (ericgodwin)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dependabot PRs fail
require-changelog-fragment.yamlbecause dependency bumps don't carry achangelog.d/fragment, and shouldn't need one. Every Dependabot PR needs a manual override to merge.Fix
Skip
check-fragmentwhen the PR carries thebotlabel. Dependabot already appliesboton both thegithub-actionsanduvupdate configs in.github/dependabot.yml, so this needs no dependabot.yml changes, just the job'sifcondition.Also skip it when the PR doesn't touch
packages/at all: docs, root-level files, and CI config were never going to need a fragment, sincecheck-fragmentonly ever inspectspackages/<package>/paths. A newdetect-scopejob usestj-actions/changed-files(matching the convention already used indetect-affected-packages) as an allow-list onpackages/**, so this covers.github-only, docs-only, and root-only PRs alike without an ignore entry per top-level directory.A job that sometimes doesn't run can't be a required status check, so
check-fragmentalone can't stay required. Addedchangelog-fragment-status, a final gate that always runs and useslowlydba/are-we-goodto rolldetect-scopeandcheck-fragment's results into a pass on either a real success or an accepted skip.Important
Branch protection needs to require
changelog-fragment-statusinstead ofcheck-fragmentfor this to take effect.Fixes #644