[CHORE](ci) Add all-Python-checks gate, resolve Build job-name collision - #648
Merged
John McCall (lowlydba) merged 4 commits intoAug 11, 2026
Conversation
check-python-code.yaml's check matrix produces one status per cell with no aggregator, so a required-status-check rule has to track six names and misses any new Python version until updated. test-schema.yaml and schema-pr-preview.yml both name their job Build, ambiguous once test-schema.yaml gets a pull_request trigger and needs pinning itself. Adds an all-python-checks-pass job to check-python-code.yaml (needs: [check], if: always()) using lowlydba/are-we-good to roll the matrix's per-cell results into one pass/fail. Renames schema-pr-preview.yml's build job from Build to Build preview, leaving test-schema.yaml's Build as the stable name #646 already plans to pin. Fixes #647 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
push never fires for fork PRs, so a required-status-check rule depending on test-schema.yaml would deadlock every fork PR. Adds a pull_request trigger alongside push, and switches the concurrency group's PR fallback to github.event.pull_request.number so per-PR runs don't collide. Cherry-picked from #638's test-schema.yaml hunk, that PR's scope is the unrelated Phase 3 publish workflows and won't merge soon, this piece can't wait on it since it's needed to verify the Build job actually triggers and reports on a fork PR per #647's acceptance criteria. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates GitHub Actions workflows to ensure schema and Python checks behave reliably for PRs (including forks) and to provide stable required-check names.
Changes:
- Add
pull_requesttrigger and adjust concurrency grouping for schema-related CI. - Rename the schema PR preview build job for clearer check-run naming.
- Add an “All Python checks pass” aggregator job to provide a single stable required status for a Python version matrix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test-schema.yaml | Adds PR trigger + updates concurrency group key to work with fork PR required checks. |
| .github/workflows/schema-pr-preview.yml | Renames the build job to produce a clearer check-run name. |
| .github/workflows/check-python-code.yaml | Adds a matrix-aggregating job intended to provide one stable required check name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Seth Fitzsimmons (sethfitz)
approved these changes
Aug 6, 2026
…i-check-names-1fcec4
John McCall (lowlydba)
temporarily deployed
to
staging
August 7, 2026 17:22 — with
GitHub Actions
Inactive
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
John McCall (lowlydba)
requested review from
Seth Fitzsimmons (sethfitz) and
Victor Schappert (vcschapp)
August 10, 2026 15:58
Seth Fitzsimmons (sethfitz)
approved these changes
Aug 10, 2026
…i-check-names-1fcec4
Eric Godwin (ericgodwin)
approved these changes
Aug 11, 2026
John McCall (lowlydba)
deleted the
lowlydba-issue-647-devops-stabilize-schema-ci-check-names-1fcec4
branch
August 11, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two check-name problems #647 flags, blocking more of #646's checks (omf-github-terraform#96) from being pinned as required.
Problem
check-python-code.yaml'scheckmatrix produces one status per cell (Check (default, py3.10)…Check (lowest-direct, py3.10)) with no aggregator, so a required-check rule has to track six names and misses any new Python version until the rule catches up.test-schema.yamlandschema-pr-preview.ymlboth name their jobBuild, ambiguous oncetest-schema.yamlgets apull_requesttrigger and needs pinning itself. Andtest-schema.yamlispush-only today, which would deadlock a required check for every fork PR.Fix
all-python-checks-passjob tocheck-python-code.yaml(needs: [check],if: always()), usinglowlydba/are-we-goodto roll the matrix's per-cell results into one pass/fail check.schema-pr-preview.yml'sbuildjob fromBuildtoBuild preview, leavingtest-schema.yaml'sBuildas the stable name [Devops] Wire schema's CI checks up as required status checks (safe-settings in omf-github-terraform) #646 already plans to pin.pull_requesttrigger totest-schema.yamlalongside its existingpushtrigger, and switches its concurrency group's PR fallback togithub.event.pull_request.numberso per-PR runs don't collide.Note
#647 names #638 as the companion PR for the
test-schema.yamltrigger fix. #638 turned out to be a much larger, unrelated Phase 3 publish-workflow PR (14 files, still blocked/unmerged) with that fix buried in one small hunk. Rather than wait on #638 or pull its whole scope in here, this PR cherry-picks just that hunk since it's needed now to verifyBuildactually triggers on a fork PR per #647's acceptance criteria. #638 still owns its own unrelated diff and should drop this hunk when rebased, or land it as a no-op.Testing
No test suite covers workflow YAML. Confirmed all three files parse with
yaml.safe_load.check-python-code.yaml's matrix, the newall-python-checks-passjob, andtest-schema.yaml'sBuildjob will all run on this PR since it's same-repo.The acceptance criterion still needs a genuine external fork PR to confirm
BuildandBuild previewdon't collide andpush-only workflows don't deadlock. That can't be verified from this branch and needs a maintainer to confirm before any of these get pinned as required.