Gate the wide-observable test helpers on their users' features and lint pecos-decoders with default features in CI - #696
Open
ciaranra wants to merge 2 commits into
Open
Conversation
…nt pecos-decoders with default features in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy -p pecos-decoders --all-targets -- -D warningswith default features has been red ondev: three helpers in thespec::buildtest module (width_dem,assert_wide_correct,assert_64_then_65_rejected) are only called from tests gated on optional decoder features, so a default-feature build sees dead code. Workspace-wide clippy never showed it because feature unification enables those features, and CI's per-crate default-feature lane did not include this crate.Changes
pecos-decodersis added to the "clippy without LLVM features" per-crate lane inrust-test.yml, so a default-feature regression in this crate fails CI instead of hiding behind workspace feature unification.Verification
cargo clippy --locked -p pecos-decoders --all-targets -- -D warnings: clean for default features,--all-features, and each of the eight features alone (ldpc,fusion-blossom,mwpf,pymatching,tesseract,chromobius,relay-bp,uf), and via the exact CI-lane invocation from inside the crate directory.cargo test --locked -p pecos-decoders: 29 pass (default), 46 pass (--all-features).pecos-foreign,pecos-quantum,pecos-qec,pecos-phir,pecos-neo,pecos-lindblad,pecos-zx,pecos-wasm,pecos-simulators,pecos-core,pecos-qasm,pecos-phir-json,pecos) found no other instance.pre-commit run --all-files: pass.