Seed the two unseeded RNG uniformity tests so they cannot fail by chance - #728
Open
ciaranra wants to merge 1 commit into
Open
Seed the two unseeded RNG uniformity tests so they cannot fail by chance#728ciaranra wants to merge 1 commit into
ciaranra wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_randint_uniformityandtest_choice_uniformityinpython/pecos-rslib/tests/test_numpy_random_comparison.pyrun a chi-square test atp > 0.01on unseeded draws. By construction that fails about one CI run in a hundred; it took down thepr-core-python (rest)shard on #711 (p=0.0093) for a change that does not touch the RNG.Every other statistical test in the file already calls
pc.random.seed(...)"for deterministic test behavior". This applies the same convention to the two that were missed, with seeds not used elsewhere in the file.Verification
4 passed.
pre-commit run --fileson the changed file: all hooks pass.