get_model_for_condition: don't remove rate rules for condition-table overrides - #520
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 76.14% 76.14%
=======================================
Files 67 67
Lines 7524 7526 +2
Branches 1341 1341
=======================================
+ Hits 5729 5731 +2
Misses 1294 1294
Partials 501 501 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…overrides `get_model_for_condition` removed *any* SBML rule (including rate rules) for a species/compartment/parameter overridden in the condition table. For rate-rule targets, this turned dynamic species into constants instead of just setting their initial value. Only assignment rules are removed now; rate rules are left in place. Fixes PEtab-dev#197 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dweindl
force-pushed
the
fix-197-rate-rules
branch
from
September 22, 2026 06:16
2b7ea00 to
a65b405
Compare
dweindl
marked this pull request as ready for review
September 22, 2026 06:20
dilpath
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
get_model_for_conditionremoved any SBML rule (including rate rules) for a species/compartment/parameter overridden in the condition table. For rate-rule targets, this turned dynamic species into constants instead of just setting their initial value.Only assignment rules are removed now; rate rules are left in place.
Fixes #197