Repository navigation
Conversation
Discover rate limiter registrations from service providers and their helpers. Complete, navigate, hover, and validate names in throttle middleware and RateLimited constructors, keeping incomplete registration sets open. Add regression tests and Laravel runtime examples, update the changelog, and remove the completed backlog item. Normalize macOS test paths and keep the middleware demo within the documented diagnostic baseline. Validation: full Rust suite, doctests, semantic-export, clippy for all native targets and WASI, formatting, PHP lints and runtime assertions, framework analysis, and benchmark sharding helper tests. Changed executable Rust line coverage: 100% (369/369).
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds completion, hover, go-to-definition, and unknown-name diagnostics for Laravel rate limiters (L58). Names registered with
RateLimiter::for()are available inthrottle:namemiddleware andnew RateLimited('name').Registrations are cached from application and package service providers and their helpers without booting the application. Numeric inline limits remain values, and unreadable sources or dynamic registration names keep diagnostics open. Provider edits refresh the names.
Includes regression tests, Laravel demos and runtime assertions, a changelog entry, and removal of the completed backlog item. Also normalizes macOS test fixture paths and keeps the middleware demo within the documented three-error diagnostic baseline.
Validation
cargo llvm-covagainstmain.Checklist
CHANGELOG.mdREADME.md,docs/,examples/)config-schema.json) — not applicable; no configuration changes.