Repository navigation
Conversation
stubbedev
force-pushed
the
fix-stale-pull-diagnostics
branch
from
November 9, 2026 14:15
e8e8ed7 to
f603a36
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Neovim sends textDocument/diagnostic right after every didChange. The edit is parsed on a background task that only then queues the file's diagnostic pass, so that pull was answered from the cache of the previous text, as `unchanged` when the client echoed the last resultId. The fresh set was announced with workspace/diagnostic/refresh, which Neovim answers with a workspace pull only and ignores for buffers it pulls one document at a time, so the stale diagnostics stayed until the buffer was reloaded. A pull sent while the project was still being indexed at startup was answered with an empty set the same way. A document pull now waits, without computing anything on the request path, until the diagnostics reflect the document's current text: for startup to finish, for the edit's parse (tracked from didChange until the parse has queued the pass), for the queued pass, and for the pass in flight. Each stage hands the URI on before letting go of it, so the wait never sees a gap. A newer pull for the same document releases the held one, so a typing burst holds at most one request per document; cancellation, shutdown and the worker stopping release held pulls too. Closes PHPantom-dev#562
stubbedev
force-pushed
the
fix-stale-pull-diagnostics
branch
from
November 9, 2026 14:49
f603a36 to
180ac27
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #562
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,examples/)config-schema.json)the changes and why they are needed.
the changelog, and other user-facing content, and removed or corrected
anything inaccurate, unclear, or unnecessary.