Skip to content

Add MPNST treated drug-combination experiments - #488

Open
jjacobson95 wants to merge 1 commit into
mpnst-treated-samples-and-omicsfrom
mpnst-treated-experiments
Open

jjacobson95 wants to merge 1 commit into
mpnst-treated-samples-and-omicsfrom
mpnst-treated-experiments

Conversation

@jjacobson95

@jjacobson95 jjacobson95 commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Pipeline Hardening/Debugging PR # 10

Add MPNST treated drug-combination experiments

Adds the experiment-generation half of the MPNST treated update: treated-microtissue drug-combination experiments, plus fixes to how drug data is pulled from Synapse. This is the largest PR in the stack, because most of it is one new script that cannot be meaningfully broken up.

Reviewer note: how to read this efficiently

The heavy file is 03_get_experiments_with_treated.R (1,640 new lines). To review the actual change in logic rather than reading it cold, compare it against the preserved original:

git diff mpnst-treated-experiments -- \
  coderbuild/mpnst/03_get_experiments_orig.R \
  coderbuild/mpnst/03_get_experiments_with_treated.R

03_get_experiments_orig.R is the pre-change script, kept in the tree specifically for this comparison. The most useful areas to focus on are the treated-microtissue (MT) code path and the step that combines treated and untreated results.

New treated-experiment builder (03_get_experiments_with_treated.R)

  • Generates the treated microtissue drug-combination experiments.
  • Carries verbose, section-by-section logging and guards so that an empty intermediate result prints clear diagnostics instead of crashing the downstream steps. It also has explicit per-section skip switches (MT / PDX / combine) that make it possible to re-run just one part while debugging; all are left enabled by default.

Drug-data source fixes (02_get_drug_data.R)

  • Handles a Synapse manifest column that was renamed from PDX_Drug_Data to PDXDrugData in 2025 by checking for either name.
  • The values in that column may now be file names rather than Synapse IDs, so it filters to genuine syn######## entries before querying, and skips PDX drug extraction cleanly when the column is absent.

Existing experiment script and packaging

  • 03_get_experiments.R: substantial reconciliation so the untreated path stays consistent with the new treated path.
  • 03_get_experiments_orig.R: preserved original, kept for the diff described above.
  • build_exp.sh / build_drugs.sh: run the treated experiment steps.
  • requirements.r: R dependencies for the experiment step.

Scope: 7 files (about 2,648 added lines). Base: mpnst-treated-samples-and-omics. Large by nature: the treated-experiment logic is a single script.

Closes #394

@jjacobson95 jjacobson95 added new data Request for additional data to be added data update labels Sep 22, 2026
@jjacobson95 jjacobson95 modified the milestones: 2.3 new build, 2.4 new build Sep 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data update new data Request for additional data to be added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant