Add MPNST treated drug-combination experiments - #488
Open
jjacobson95 wants to merge 1 commit into
Open
jjacobson95 wants to merge 1 commit into
jjacobson95 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline Hardening/Debugging PR # 10
Add MPNST treated drug-combination experiments
Adds the experiment-generation half of the MPNST treated update: treated-microtissue drug-combination experiments, plus fixes to how drug data is pulled from Synapse. This is the largest PR in the stack, because most of it is one new script that cannot be meaningfully broken up.
Reviewer note: how to read this efficiently
The heavy file is
03_get_experiments_with_treated.R(1,640 new lines). To review the actual change in logic rather than reading it cold, compare it against the preserved original:03_get_experiments_orig.Ris the pre-change script, kept in the tree specifically for this comparison. The most useful areas to focus on are the treated-microtissue (MT) code path and the step that combines treated and untreated results.New treated-experiment builder (
03_get_experiments_with_treated.R)Drug-data source fixes (
02_get_drug_data.R)PDX_Drug_DatatoPDXDrugDatain 2025 by checking for either name.syn########entries before querying, and skips PDX drug extraction cleanly when the column is absent.Existing experiment script and packaging
03_get_experiments.R: substantial reconciliation so the untreated path stays consistent with the new treated path.03_get_experiments_orig.R: preserved original, kept for the diff described above.build_exp.sh/build_drugs.sh: run the treated experiment steps.requirements.r: R dependencies for the experiment step.Scope: 7 files (about 2,648 added lines). Base: mpnst-treated-samples-and-omics. Large by nature: the treated-experiment logic is a single script.
Closes #394