Migrate build scripts to coderbuild/utils and remove dead scripts - #500
Open
jjacobson95 wants to merge 1 commit into
Open
jjacobson95 wants to merge 1 commit into
jjacobson95 wants to merge 1 commit into
Conversation
Move the build-invoked scripts (check_schema, map_improve_sample_ids, map_improve_drug_ids, align_drug_descriptors, push_to_figshare) from scripts/ into coderbuild/utils/, update their invocation paths in build_all.py and build_dataset.py, and add coderbuild/utils to the upload image. Remove unused scripts update_version.py, figshare_pull.py, and assign_improve_ids.py.
ymahlich
approved these changes
Sep 28, 2026
ymahlich
left a comment
ymahlich
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me.
I don't think that the push_to_pypi script is still necessary since the pyproject.toml and hatch should be taking care of this, but keep it for now.
Once a version tag for v2.4 has been created and we have successfully published we can revisit that and remove the push_to_pypi script in the next version.
@jjacobson95 Maybe create an issue for that so we keep track of if.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline Hardening/Debugging PR # 17
Move the build-invoked scripts (check_schema, map_improve_sample_ids, map_improve_drug_ids, align_drug_descriptors, push_to_figshare) from scripts/ into coderbuild/utils/, update their invocation paths in build_all.py and build_dataset.py, and add coderbuild/utils to the upload image. Remove unused scripts update_version.py, figshare_pull.py, and assign_improve_ids.py.
Adding both of you for review because I removed (and migrated) a couple of scipts and I want to make sure that these are not required for anything anymore. I kept in push_to_pypi.py but will remove if not useful anymore - @ymahlich(?)
Closes #296.