Repository navigation
Conversation
dddd-jh
requested review from
benemer,
mehermvr,
saurabh1002 and
tizianoGuadagnino
as code owners
October 5, 2026 14:27
Member
|
AI-Bots based users do not go on the contributor list. The issue will be fixed as a separate PR. |
Merged
saurabh1002
added a commit
that referenced
this pull request
Oct 6, 2026
* remove redundant move * Fix refelction bug in Kabsch-Umeyama as suggested in #118
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2D Kabsch fit can return a reflection, or reject valid correspondences and return a NaN pose.
-Rdoes not correct a reflection in two dimensions:det(-R) == det(R). The translation also uses the original matrix rather than the matrix assigned to the transform.For example, reference points
(4, 7)and(6, 7), transformed by a 180-degree rotation and translation(2, -3), produce zero inliers and a NaN translation on the current implementation in my local build. A mirrored narrow rectangle centered at the origin produces four inliers but a final rotation determinant of-1.This changes the SVD fit to
V * diag(1, sign(det(V * U.transpose()))) * U.transpose(), correcting the smaller singular direction. Both rotation and translation use this corrected matrix.Adds nine regression cases through the public
RansacAlignment2DAPI: translated two-point fits at six angles, a noncollinear fit, and reflected rectangles at zero and nonzero reference centroids. They check finite output, all expected inliers, orthogonality, determinant+1, the centroid mapping and the expected proper rigid fit. Checks use explicit failure returns so they remain active in Release builds. The reflected rectangles are small enough that every sampled proper fit includes all four points under the existing inlier threshold.The tests are opt-in via
-DBUILD_TESTS=ON, use no additional test framework dependency, and run via CTest in both existing C++ CI jobs.Validation:
I have not built the full OpenCV/Sophus-dependent library or run the complete map-closure pipeline locally. The updated upstream CI covers the full library build on its existing platform matrix.