Remove PSModule PR-template distribution and use canonical authoring guidance

Describe the change

Context and request

Remove PR-template distribution from PSModule/.github. Authors use canonical PR-format guidance directly, not a repository-owned file or an organization fallback. This is the user-directed reversal of the earlier scaffold implementation, delivered by the existing scoped PR #82.

User request, verbatim: "I do not want the template or any other repo to have the PR template in the repo. Please remove it." Selected clarification: "Remove central defaults too; use canonical PR-format guidance only".

The authoring contract still requires complete consumer actions or a justified no-action result, applicability, prerequisites, ordering and verification in PR/release records. Canonical guidance owns summary/announcement placement, result-scoped evidence and route-applicable release decisions. Removing a GitHub PR-template file does not move release-specific instructions/history into repository docs.

Acceptance criteria

No actual GitHub PR-template file remains in the isolated candidate: root, .github, docs and their single-file or PULL_REQUEST_TEMPLATE directory variants are checked. No central fallback, replacement template or copied scaffold is introduced.
Direct README/contribution guidance links canonical MSX PR Format and states the no-file distribution contract without claiming automatic inheritance of a PR scaffold.
Other community defaults, Feature/Bug issue forms, repository-specific contribution content, agent routes and the operational Require and independently verify the community validation check on main #85 audit are preserved.
The separate validator owner receives the exact removed paths and owns all changed presence expectations, fixtures, helper/source checks and workflow. This PR modifies no validator or consumer installation.
Existing ruleset 26275706, Community file validation context, integration 15368, strict freshness and inherited review constraints are unchanged. No manually successful scan or check result substitutes for real exact-head validation.
The updated PR/Task describe the user reversal and current source status; older frozen scaffold/template correspondence is historical evidence, not authority for distribution. The PR stays draft until fresh exact-head validation and the complete review loop hold.

Constraints and non-goals

One scoped repository delivery. No live governance changes, merge, auto-merge, publication, tag movement, unrelated cleanup, marketplace/skills, consumer fleet or label removal. Do not alter Feature/Bug forms, duplicate a consumer template, add migration guides/changelogs or install this validator in ordinary module repositories.

PSModule/Template-PSModule#40 is non-closing context. Its deleted-file request must be reconciled with the user-directed no-file distribution decision, not solved by recreating a template or closed solely because its previous target is absent.

Technical decisions

The current removal candidate contains no actual PR-template file. Pre-removal inventory identified exactly .github/pull_request_template.md, with no root/docs alternatives or multiple-template directory members. This file is deleted outright with no replacement; recursive on-disk and complete pushed-tree checks verify zero variants. Update only the directly coupled canonical-authoring paragraph in README.md and the inherited-template paragraph in .github/CONTRIBUTING.md. Keep all other community files intact.

Canonical source correspondence is now MSXOrg/docs#209 at live head bc03a5992615f65d1d5346dc48e7506e80b8b6ca, ready for review but unmerged. The Repository Standard no-PR-template-file policy owns the universal prohibition, including both organization-default sources. Organization Standard and repository governance preserve other community defaults and genuine local contribution/product-integration contracts. PR Format itself owns the authoring procedure and complete description example, not template-file distribution or deletion policy. The old copy-the-complete-template anchor is not current.

For release-bound records the final publication-baseline-first analysis precedes classification and action/compatibility claims. Preserve the complete authored body, ordered applicable groups, one announcement marker, scoped evidence, defaults and Task/Bug planning. This community-default route has no artifact publisher, so it records its exact scoped comparison without inventing a publication baseline or release decision. Prior frozen scaffold-copy pins are historical evidence only; no scaffold is recopied into the repo. Existing local authoring links already satisfy this separation, so this correspondence update needs no repository file edit or new commit.

The measured live main baseline f424237c98b5b020f80e8c9563dbc37256fc1ec0 still contains .github/pull_request_template.md (blob 13e45de9d91b403a54a04dfa4fdbff34345a32f3). The no-file outcome is the isolated candidate 0f0cef0c1fbb582bf7bf29c26ad96fee0d6d0bc4, not an integrated deletion. Source readiness and verified correspondence do not imply merge or auto-merge authorization.

Validation code is independently owned by #84 and #86. The exact planned removed path was sent to that owner before editing; this PR does not change presence guards, fixtures, helper, workflow or validation dependencies. The README authoring paragraph and contribution guidance belong to this delivery; validator-specific documentation remains the code owner's surface.

The existing native blocked-by PBI #83 remains intact. Operational Task #85 stays open for remaining and post-integration verification. Rule 26275706 is already active for main only and is not altered. At the inspected state, repository main has no integrated validator and this PR has no exact-head Community file validation result; those are real draft prerequisites, not a reason to fabricate or dispatch a substitute.

Implementation plan

Inventory all actual template routes and reproduce the expected no-template contract failure before editing.
Send the exact removed path and scope boundaries to the separate validator owner before writes.
Delete the actual PR-template file with no replacement and update only directly coupled README/contribution authoring guidance.
Verify the absence of all recognized file/directory variants, working/base-to-head whitespace, canonical links and preservation of other community files; commit/push the focused removal.
Run a fresh explicit complete Copilot review on the exact removal head, including all summaries/threads, and handle scoped feedback.
Reconcile current canonical owner correspondence and scoped issue evidence, retain any unmet exact-head CI/integration prerequisites, and publish the revised existing draft PR.

Test-first verification reproduced the expected baseline failure: the old inherited fallback does not contain the complete canonical scaffold. The native Task type is confirmed as Task. Implementation now targets the pinned complete body; the draft source and missing required-check enforcement remain explicit readiness prerequisites.

The complete pinned body now passes source-correspondence and structure assertions, and the focused template commit is pushed in draft #82. Direct contribution guidance and final review/evidence remain in this Task. The source candidate and required-check enforcement are not yet readiness passes.

Direct contribution guidance is committed and pushed separately in #82. All five direct guidance links return HTTP 200, and native working/staged whitespace checks pass. The repository delta remains exactly the fallback scaffold and its direct contribution guidance; release-specific migration history is not stored in repository docs.

Recorded a native blocked-by dependency for the separately scoped required-validation/enforcement Task #83. The scaffold PR remains draft while that prerequisite and the governing source candidate are open. No workflow, ruleset, permission, tag, release, or merge setting was changed to work around the gate.

Final local authoring validation passes on e7f3df053e276e1fe1fbc9ee6060ca25bae54f5f: complete canonical body correspondence; one marker; five ordered classifier groups; one Technical details/Related references pair per result; complete applicability/action/intermediate/source/template prompts; canonical labels; six anonymous managed/unmanaged/internal-only authoring fixtures; full GitHub GFM rendering; all five direct contribution links returning HTTP 200; and git diff --check, git diff --cached --check, and git diff main...HEAD --check.

The correspondence command is reproducible from the repository checkout (PowerShell 7 and authenticated gh; no added repository tooling):

$ErrorActionPreference = 'Stop'
$ref = '48533dcc70d8bc344f8192bfad8de25a8fdaabe9'
$source = (gh api "repos/MSXOrg/docs/contents/src/docs/Ways-of-Working/PR-Format.md?ref=$ref" -H 'Accept: application/vnd.github.raw+json') -join "`n"
if ($LASTEXITCODE -ne 0) { throw 'Cannot retrieve the pinned source.' }
$matches = [regex]::Matches($source, '(?ms)^````markdown\r?\n(?<body>.*?)\r?\n````$')
if ($matches.Count -ne 1) { throw 'Expected one complete canonical scaffold.' }
$template = (Get-Content -LiteralPath '.github\pull_request_template.md' -Raw).Replace("`r`n", "`n")
$body = [regex]::Replace($template, '\A<!--.*?-->\n\n', '', [System.Text.RegularExpressions.RegexOptions]::Singleline)
if ($body.TrimEnd("`r", "`n") -cne $matches[0].Groups['body'].Value.TrimEnd("`r", "`n")) { throw 'Source correspondence failed.' }
@{ text = $body; mode = 'gfm'; context = 'PSModule/.github' } | ConvertTo-Json -Depth 5 | gh api --method POST markdown --input -
if ($LASTEXITCODE -ne 0) { throw 'GitHub GFM rendering failed.' }
git diff main...HEAD --check
if ($LASTEXITCODE -ne 0) { throw 'Whitespace validation failed.' }

Anonymous fixture checks exercise authoring output shapes, not the runtime release resolver: unmanaged reader-facing, unmanaged internal-only, managed default with Labels: None, prerelease with a default bump, explicit bump override, and managed no-release retaining only Release/Labels. The complete rendered scaffold contains five classifier headings, five Technical details blocks, five Related references blocks, and one conditional Release decisions block.

The submitted review on the same head is a clean code-feedback round: zero inline comments, zero unresolved threads, and no changes requested. Its summary explicitly says the draft governing source and CI/governance prerequisites need confirmation before approval. Those summary concerns are retained, not treated as an approval or a validation-gate pass.

The six scoped implementation, verification, complete-review, convergence, and readiness-recording steps are complete in #82 at e7f3df0. The working tree is clean and the complete scaffold still matches the unchanged source candidate at 48533dcc70d8bc344f8192bfad8de25a8fdaabe9. The PR remains draft: MSXOrg/docs#209 is draft/unmerged, and the native required-validation/enforcement prerequisite is open. Task completion/closure still requires the reviewed merge; neither this Task nor PSModule/Template-PSModule#40 is closed.

The exact live MSXOrg/docs#209 candidate is now 1ececb2bd9f1680c87cec15a45ac927a554fce9c. Its complete scaffold is unchanged from 3d388e283c2e20d88d112b2951c4df857e955821; relative to the earlier 48533dcc70d8bc344f8192bfad8de25a8fdaabe9 pin, exactly five Technical details prompts changed. The ordinary follow-up commit updates only those prompts to name delivery-leaf plan progress and convergence search scope/outcome even when nothing else converges. Complete-body equality, five-prompt surgical-delta checks, and native working/staged whitespace checks pass. CONTRIBUTING and all unrelated files remain unchanged by this revision. The final-head review is being rerun; independent code validation and any operational enforcement remain outside this Task, with no live enforcement authorization.

Renewed verification passes on 90aee54bd9df1f3a716a5fb8a0707ccba4b56f22 against exact candidate MSXOrg/docs@1ececb2bd9f1680c87cec15a45ac927a554fce9c: complete scaffold equality, all five explicit delivery-plan/convergence prompts, classifier order, scoped block pairs, one marker, canonical labels, and exact surgical-delta equality with only the five prompt replacements.

git diff --check, git diff --cached --check, and git diff main...HEAD --check pass. GitHub GFM rendering passes with five classifier headings, five Technical details blocks, five Related references blocks, and one conditional Release decisions block. Six anonymous managed/unmanaged/internal-only authoring fixtures pass. Invoke-WebRequest -Uri $url -MaximumRedirection 5 returns HTTP 200 for all five direct CONTRIBUTING links. The three pinned source paths and their linked headings resolve at the exact candidate.

The earlier reproducible correspondence command applies with $ref = '1ececb2bd9f1680c87cec15a45ac927a554fce9c'. These are scaffold/output-shape checks, not a release-resolver or enforced-CI claim. The follow-up commit preserves CONTRIBUTING byte-for-byte and changes no other repository surface. The current scoped issue sweep finds no fully convergent issue beyond this Task; the separately owned validation/enforcement Task stays open and blocked-by, and PSModule/Template-PSModule#40 stays open. Final-head automated review is explicitly requested and pending; the governing candidate is still draft/unmerged, and no live enforcement is authorized.

The explicit renewed review converged on 90aee54: no code findings, no changes requested, zero inline comments, and zero unresolved review threads. The complete summary at #82 (review) explicitly retains the draft/unmerged canonical source and unresolved candidate-head validation/protection prerequisites. Those concerns are recorded, not dismissed or treated as approval. Exact source correspondence remains 1ececb2bd9f1680c87cec15a45ac927a554fce9c. The PR stays draft; code validation and operational enforcement are separate ownership, and no live enforcement, merge, auto-merge, release, or tag action was performed.

Independently verified the user-approved main-only validation rule and preserved inherited review constraints; durable evidence and unavailable live cases are recorded in #85 at #85 (comment). The named required check/source and strict freshness conditions are satisfied on the inspected current code candidate, not on this scaffold head. The body now reflects actual applied enforcement and the ready-but-unmerged governing source, whose scaffold remains unchanged. This PR stays draft pending normal source/code integration and its own refreshed current-head PR-event validation. No policy/check/result mutation or merge attempt occurred, and no separate code/operational/aggregate issue is closed.

Retain the explicit validator containment readiness hold: the separate code owner reproduced a parent-directory junction/symlink escape and added its test-first correction. Independent current-head rule/context evidence is updated at #85 (comment), distinguishing earlier a009b62 successes from the advanced 6609aa5 native check. Green CI alone is not reviewed containment or code-readiness approval. Require the fresh reviewed corrected candidate before later operational/scaffold milestones; this PR still needs its own refreshed PR-event result after normal integration and stays draft. No policy, check result, code, cleanup, merge or approval was changed here.

The previous validator containment/fresh-review blocker is resolved, not current unfinished work. Independently inspected #86 at 6609aa5: non-draft, unmerged, no auto-merge; head-bound review 5723598524 reports No open issues and retains only the generic symlink/dependency-exclusion human-assessment caution. The ready-event native Community file validation check from app 15368 succeeds on that exact SHA, with 23 fixtures and 10 real files. Current evidence is preserved at #85 (comment) and in this PR description.

#82 remains draft at the unchanged scaffold head with no named file-validation result. #85 stays open for remaining/post-integration verification; obtain a refreshed current-head PR-event result on this scaffold after actual authorized normal integration. Canonical source and validation code remain unmerged. No human approval, integration, policy/check mutation or merge is claimed, and no code/operational/aggregate scope is closed.

User-directed reversal: remove central defaults too and use canonical PR-format guidance only. The current Task replaces its earlier scaffold-copy acceptance criteria; those prior source pins/checks remain historical comments, not current distribution authority. Test-first inventory confirmed the one actual file .github/pull_request_template.md and failed the required no-file condition before editing. The exact deletion and separate README/CONTRIBUTING versus validator ownership boundaries were sent to the #86 owner. No other community files, Feature/Bug forms, active rule or #85 audit will change in this delivery.

The user-directed removal is committed and pushed in #82 at 0f0cef0. Exactly .github/pull_request_template.md is deleted; no replacement or multiple-template directory exists. Only README.md and .github/CONTRIBUTING.md authoring pointers accompany the deletion. Recursive candidate inventory, three-surface scope checks, working/staged/full-candidate whitespace, four direct HTTP-200 reference links and both GitHub GFM doc renderings pass. Other community files, Feature/Bug forms and validator/governance/audit surfaces are preserved. The validator owner confirmed separate removal of the template presence requirement/copied fixtures and received this exact removal head; no workflow was copied between branches. Fresh removal-head review and actual required CI remain unfulfilled draft gates.

The separately owned validator session reports a data-only compatibility experiment against this exact removal head, 0f0cef0: zero actual PR-template variants, nine Markdown files checked, and fail-closed MD025/removed-CONTRIBUTING cases. It reports 22 passing local regressions with no copied PR-template fixture. This is that owner's local candidate evidence, not a required hosted check or an experiment run by the scaffold session. The later native PR-event result still requires normal integration of the separately revised validator.

Current canonical source inspection at be8c340fa3554f525bb20ade4859e75b81b78ec6 still contains the previous organization-template paragraph in its contribution guide and is draft/unmerged while its no-file revision is in progress. The user reversal is explicit; do not treat that old paragraph or earlier frozen scaffold pins as authority to recreate or distribute a template. This candidate keeps only canonical authoring links and remains draft for renewed canonical correspondence, exact-head review and actual CI.

Fresh explicit review on removal head 0f0cef0c1fbb582bf7bf29c26ad96fee0d6d0bc4 converged: zero new inline comments, no changes-requested review, and zero unresolved threads. The full review 5724973589 reports No open issues but explicitly retains missing exact-head Community file validation, pending canonical no-file guidance and separately owned validator integration. These summary concerns are recorded as real draft prerequisites, not waived by the code-feedback result.

The required named file-validation check remains absent; the successful current-head Copilot check is a different context. Main remains f424237c98b5b020f80e8c9563dbc37256fc1ec0 with no integrated validator. The separately owned validator candidate is now 1d4538550a31d71d45a35ae9a0ae1a621f0fe00e; its owner's data-only compatibility experiment checks this exact no-template candidate's nine Markdown files and fail-closed mutations, but it is local evidence, not this PR's hosted result. Safe ordering remains normal validator integration followed by this removal PR's own refreshed PR-event validation.

Canonical MSXOrg/docs#209 remains draft/unmerged at be8c340fa3554f525bb20ade4859e75b81b78ec6 while revising the no-file contract. The direct canonical authoring link is retained, not an old frozen template-distribution claim. Rule26275706, exact context/app15368/strictness, inherited review controls, Feature/Bug forms and operational #85 audit are unchanged. Related PSModule/Template-PSModule#40 received the no-central-fallback reconciliation and remains open. No template replacement, consumer-validator installation, governance/check-result mutation or merge occurred.

The revised no-template candidate and native Task are published with verified attachment cards. Head 0f0cef0 has zero actual PR-template files/directories locally and in the complete pushed tree, no replacement, only the three owned changed surfaces, and a clean working tree. The complete removal-head review and summary are recorded. This completes scoped implementation/evidence steps, not merge readiness or issue closure: required exact-head file validation is absent, canonical no-file revision and separate validator integration remain pending, and the native PBI/#85 operational completion stay open. No Feature/Bug form, validator code, live rule, audit, check result or merge state changed here.

Final canonical owner correspondence is live MSXOrg/docs#209 head bc03a5992615f65d1d5346dc48e7506e80b8b6ca, ready but unmerged. Its no-file rule is now explicitly owned by Repository Standard, with Organization/Governance source pointers; PR Format owns the complete-description-example and actual-publication-baseline-first authoring protocol, not GitHub template-file policy. All five pinned paths/heading anchors were read and verified. Existing local authoring links need no file change, and no obsolete copy-the-complete-template link remains in current repo docs. The measured current main still contains the legacy template; deletion remains only the no-file candidate 0f0cef0. The exact-head clean review is retained, but required native validation and separate validator integration are still missing readiness evidence. No rule, audit, workflow, consumer or merge change occurred.

Independently rechecked the deletion-aware validator dependency: #86 is non-draft and unmerged at 26463d1, with successful current/ready-event Community file validation checks from GitHub Actions app 15368. The full head-bound review 5725027180 reports No open issues and retains a human-assessment caution about pre-commit staging versus committed content. This is reviewed code/check evidence, not human approval, integration, or this removal PR's native validation.

The exact removal head remains 0f0cef0 and still has no Community file validation result. Main remains f424237. The validator owner's nine-file data-only compatibility evidence remains attributed local evidence, not PR-event validation of this branch. Keep #82 draft and #85 open for normal integration and this removal candidate's own refreshed current-head check; no workflow copy, policy/result mutation or merge occurred.

Navigation Menu

Repository navigation

Remove PSModule PR-template distribution and use canonical authoring guidance #81

Describe the change

Context and request

Acceptance criteria

Constraints and non-goals

Technical decisions

Implementation plan

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Remove PSModule PR-template distribution and use canonical authoring guidance #81

Description

Describe the change

Context and request

Acceptance criteria

Constraints and non-goals

Technical decisions

Implementation plan

Activity

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

MariusStorhaug commented on Oct 31, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions