Repository navigation
🩹 [Patch]: Feature requests describe consumer needs and expected behavior - #89
Open
Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
Open
Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
Conversation
6 tasks done
There was a problem hiding this comment.
🟢 Approved
No active review issues remain for the feature-request form update.
No open issues 🎉
What changed in this PR
Updates the organization’s inherited feature-request form so contributors describe their needs, motivation, and expected behavior without proposing an implementation. Existing template identity, routing labels, and the single required response remain unchanged.
Changes:
- Replaces implementation-oriented prompts with consumer-focused questions and optional plain-language starters.
- Clarifies maintainer routing and links canonical MSX issue and planning guidance.
- Adds 23 focused Pester checks covering form structure, preserved routing, and consumer-facing prompts.
| File | Description |
|---|---|
tests/FeatureIntake.Tests.ps1 |
Adds regression checks for the feature form’s structure, routing, and consumer expectations. |
.github/ISSUE_TEMPLATE/10-feature.yml |
Updates feature-request guidance and prompts while preserving submission requirements. |
Review effort: Balanced
Marius Storhaug (MariusStorhaug)
marked this pull request as ready for review
October 31, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature contributors can describe what they need, why it matters, and the behavior they expect in a real situation without proposing an implementation. PSModule repositories using the inherited feature form keep the same template identity, title prefix, declared
feature/triagelabels, and single required response.Changed: Feature requests start with consumer needs
The response is labeled Consumer need and expected behavior. Three prompts ask about the contributor's goal and who benefits, why the outcome matters, and what should happen in a real situation. Optional starters use ordinary language; no extra required fields, implementation plan, or literal Gherkin syntax is introduced. Maintainers still review feedback and choose the appropriate native issue type.
Adopting this release
No consumer-local edit is required. After merge, repositories using GitHub's inherited PSModule issue templates receive the organization-owned feature form. Repositories with local issue-template overrides are unchanged; this PR does not copy the form or the full standard into consumer repositories.
Release impact
f424237c98b5b020f80e8c9563dbc37256fc1ec0, and the immutable candidate head isa747f719e55056056ab4053e423643c031bf9028. No numeric publication coordinates are assigned.Technical details
Consumer change record
Descriptionasks for an idea, implementation suggestions, and alternatives.Consumer need and expected behaviorasks for need/beneficiary, motivation, and expected behavior in a real situation; optional plain-language starters.descriptiontextarea, original template name/description/title, declaredfeature/triagelabels, and no native type.Template baseline
The existing feature form and unchanged PR scaffold were inspected at immutable baseline
PSModule/.github@f424237c98b5b020f80e8c9563dbc37256fc1ec0. The candidate source isa747f719e55056056ab4053e423643c031bf9028; its parsed GitHub form contract retains the existing identity and routing declarations. This repository is the organization-default source, not a Process-PSModule integration-template consumer, so no framework template upgrade applies. The repository PR scaffold itself is not changed.Maintainer evidence
Only the organization-owned feature form and its focused Pester test change. The passing baseline checks were committed before opening the early draft. All 10 exact consumer checks were demonstrated red against the unchanged form before implementation; the passing final state was then pushed in three small logical commits. Internal PSModule/.github#88 remains a native Task with technical decisions and its test-first plan. GitHub's native
closingIssuesReferencescontains exactly that Task.Invoke-Pester -Path .\tests\FeatureIntake.Tests.ps1 -Output Detailed -CIInvoke-Pester -Path .\tests\FeatureIntake.Tests.ps1 -Output Normal -CIbefore the form editInvoke-ScriptAnalyzer -Path .\tests\FeatureIntake.Tests.ps1 -Severity Error,Warningyamllint --strict .github\ISSUE_TEMPLATE\10-feature.ymlgit --no-pager diff f424237c98b5b020f80e8c9563dbc37256fc1ec0 HEAD --checkhttps://msx.no/docs/Ways-of-Working/Issues/andhttps://msx.no/docs/Ways-of-Working/Issues/Process/Planning/consumer-expectationsanchor is used in the shipped form.gh pr edit 89 --repo PSModule/.github --add-reviewer '@copilot', followed by bounded reviews/comments polling for the exact heada747f719e55056056ab4053e423643c031bf9028at2026-10-31T16:35:54Z, covered both changed files, left 0 inline comments, and reported no active review issues.gh pr view 89 --repo PSModule/.github --json closingIssuesReferencesFrozen-source correspondence
The coordinator supplied the frozen handoff for MSXOrg/docs#228 and MSXOrg/docs#230 at
1c8f98cabe64b12aaa5fa9fb5f51b9d03f5de9de. Its relevant owning pages were read at that immutable source, rather than inferred from an old green check.When I ..., I expect ...starter invite an equally clear ordinary-language scenario. No architecture inventory or implementation checklist is solicited.These immutable links are review evidence only. The source PR is still unmerged, and the current canonical planning page does not yet contain the new guidance. Frozen correspondence is complete; source adoption on main is not claimed.
Standards and framework alignment
The existing README still correctly describes the repository's inherited-default role, and contribution guidance still points to the central process. The consumer documentation lives in the changed form, with the runnable check documented in the test's help; unrelated README/scaffold expansion remains outside this delivery.
Scoped convergence
The open-issue sweep was limited to the exact feature-form path. It returned this delivery Task and PSModule/.github#87. This diff improves strict lint for the edited feature form, but it does not satisfy that broader Task's all-form formatting or local/CI YAML enforcement. No additional issue is fully delivered; only this Task is closed by the PR.
Remaining readiness gates and out-of-scope observations
copilot-pull-request-reviewercheck and 0 commit statuses; combined commit-status state ispending. The active strict main rule requiresCommunity file validation, bound to integration 15368, and that required check is absent on this head (gh api repos/PSModule/.github/rules/branches/main). Copilot approval is not a substitute for that CI gate. PSModule/.github#84, PSModule/.github#85, and PSModule/.github#86 own the separate validation/governance work. This PR does not change their configuration or containment guards and does not use an old green result as proof of the correction.gh api repos/PSModule/.github/labels/featurereturns 404, whilegh api repos/PSModule/.github/labels/triageresolves the existing Triage label. The form's declared labels are preserved exactly; no live label is created, renamed, or changed. This observation is limited to this repository, not a fleet-wide claim.Relevant issues (or links)
Related work