Repository navigation
Fix cancelled running scheduled task state - #14109
Merged
Doc94 merged 2 commits intoOct 24, 2026
Merged
Conversation
metabrixkt
force-pushed
the
bug/fix-cancelled-scheduled-task-state
branch
from
August 2, 2026 19:08
d19b066 to
6131264
Compare
Contributor
Author
|
Rebased, no changes |
metabrixkt
force-pushed
the
bug/fix-cancelled-scheduled-task-state
branch
from
August 24, 2026 06:29
6131264 to
eab537e
Compare
Contributor
Author
|
Rebased, no changes |
Warriorrrr
approved these changes
Oct 8, 2026
papermc-projects
Bot
moved this from Delayed approval
to Full approval
in Paper PR Queue
github-project-automation
Bot
moved this from Full approval
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14107
Repeating scheduled tasks cancelled while they are running currently stop being rescheduled, but remain in
CANCELLED_RUNNINGafter their callback finishes.This finalizes the cancellation in all three Folia-friendly schedulers that have a task state machine once the current execution completes. The task then reports
CANCELLED, and later calls tocancel()returnCANCELLED_ALREADY.[edit] And one more thing: Folia is also gonna need a minor change in the region scheduler (beyond updating the upstream commit), which I'll probably PR shortly after this one merges (if it merges quickly)