Skip to content

Regen missing worldgen settings from server.properties - #14233

Merged
Doc94 merged 8 commits into
PaperMC:mainfrom
HaHaWTH:fix/worldgen-settings-recovery
Oct 24, 2026
Merged

Doc94 merged 8 commits into
PaperMC:mainfrom
HaHaWTH:fix/worldgen-settings-recovery

Conversation

@HaHaWTH

@HaHaWTH HaHaWTH commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Closes #14066.

This PR fixes crash when the overworld world_gen_settings.dat is missing.

Changes

Changed the recovery behavior, now will recover worldgen settings from server.properties instead of randomly picking seeds.

Tested these cases:

  • Completely deleting the dimensions/data/overworld directory
  • Only deleting world_gen_settings.dat in overworld data

Datapack settings will be merged in through bake() below so worldgen datapacks still work

@HaHaWTH
HaHaWTH requested a review from a team as a code owner September 6, 2026 05:32
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Sep 6, 2026
Doc94 added 2 commits October 9, 2026 09:48
…/worldgen-settings-recovery

# Conflicts:
#	paper-server/patches/sources/net/minecraft/server/Main.java.patch
@Doc94 Doc94 added the publish-pr Enables a workflow to build Paperclip jars on the pull request. label Oct 9, 2026
@papermc-pr-publishing

papermc-pr-publishing Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Last updated for: 47284a6ff57f0d89c1b66b223c60886bf410f8f4.

Download the Paperclip jar for this pull request: paper-14233.zip

Maven Publication

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven("https://maven-prs.papermc.io/Paper/pr14233") {
        name = "Maven for PR #14233" // https://github.com/PaperMC/Paper/pull/14233
        mavenContent {
            includeModule("io.papermc.paper", "dev-bundle")
            includeModule("io.papermc.paper", "paper-api")
        }
    }
}

@Doc94 Doc94 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make a few tests and work with the deletion and load of worlds, if any wanna try the JAR for this PR is in #14233 (comment)

@papermc-projects papermc-projects Bot moved this from Awaiting review to Delayed approval in Paper PR Queue Oct 9, 2026
@electronicboy

Copy link
Copy Markdown
Member

regenerate, not recover

@HaHaWTH

HaHaWTH commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

regenerate, not recover

I assume regen settings from server.prperties file is more aligned to user's expectations? As most server owners expect to regen the world with the same seed when deleting the single dimension folder

@Doc94

Doc94 commented Oct 11, 2026

Copy link
Copy Markdown
Member

regenerate, not recover

I assume regen settings from server.prperties file is more aligned to user's expectations? As most server owners expect to regen the world with the same seed when deleting the single dimension folder

yep, recover feels like try to get the file again like a "undo" when all this code its for generate a new one (using settings)

@HaHaWTH

HaHaWTH commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Should I just change the comment and log messages? Current logic already matches regen semantic

@Doc94

Doc94 commented Oct 14, 2026

Copy link
Copy Markdown
Member

Should I just change the comment and log messages? Current logic already matches regen semantic

Yes

@HaHaWTH HaHaWTH changed the title Recover missing worldgen settings from server.properties Regen missing worldgen settings from server.properties Oct 14, 2026
@HaHaWTH

HaHaWTH commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Should I just change the comment and log messages? Current logic already matches regen semantic

Yes

Done

@papermc-projects papermc-projects Bot moved this from Delayed approval to Full approval in Paper PR Queue Oct 24, 2026
…/worldgen-settings-recovery

# Conflicts:
#	paper-server/patches/features/0004-Entity-Activation-Range-2.0.patch
#	paper-server/patches/features/0022-Remove-debug-like-logging.patch
#	paper-server/patches/features/0026-Optimise-collision-checking-in-player-move-packet-ha.patch
#	paper-server/patches/features/0027-Attempt-to-recalculate-regionfile-header-if-it-is-co.patch
#	paper-server/patches/features/0027-Optional-per-player-mob-spawns.patch
#	paper-server/patches/features/0028-Improve-cancelling-PreCreatureSpawnEvent-with-per-pl.patch
#	paper-server/patches/features/0029-DataConverter-Moonrise-co-fixes.patch
@Doc94
Doc94 merged commit e3ba7b1 into PaperMC:main Oct 24, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Full approval to Merged in Paper PR Queue Oct 24, 2026
@HaHaWTH
HaHaWTH deleted the fix/worldgen-settings-recovery branch October 24, 2026 13:34
granny added a commit to PurpurMC/Purpur that referenced this pull request Oct 24, 2026
Upstream has released updates that appear to apply and compile correctly

Paper Changes:
PaperMC/Paper@e8a1f8fd Configurable plugin message channel limit PaperMC/Paper#14160
PaperMC/Paper@67912d08 [ci/skip] Re-enable using JBR for local run tasks again PaperMC/Paper#14318
PaperMC/Paper@02378ab5 Fire PrepareItemCraftEvent for Crafter preview PaperMC/Paper#14320
PaperMC/Paper@05c2798e Fix cancelled running scheduled task state PaperMC/Paper#14109
PaperMC/Paper@e3ba7b1d Regen missing worldgen settings file from server.properties PaperMC/Paper#14233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

publish-pr Enables a workflow to build Paperclip jars on the pull request.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

Paper refuses to start after deleting world_gen_settings.dat file

3 participants