Repository navigation
Regen missing worldgen settings from server.properties - #14233
Conversation
…/worldgen-settings-recovery # Conflicts: # paper-server/patches/sources/net/minecraft/server/Main.java.patch
|
Last updated for: 47284a6ff57f0d89c1b66b223c60886bf410f8f4. Download the Paperclip jar for this pull request: paper-14233.zip Maven PublicationThe artifacts published by this PR:Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven("https://maven-prs.papermc.io/Paper/pr14233") {
name = "Maven for PR #14233" // https://github.com/PaperMC/Paper/pull/14233
mavenContent {
includeModule("io.papermc.paper", "dev-bundle")
includeModule("io.papermc.paper", "paper-api")
}
}
} |
Doc94
left a comment
There was a problem hiding this comment.
I make a few tests and work with the deletion and load of worlds, if any wanna try the JAR for this PR is in #14233 (comment)
|
regenerate, not recover |
I assume regen settings from |
yep, recover feels like try to get the file again like a "undo" when all this code its for generate a new one (using settings) |
|
Should I just change the comment and log messages? Current logic already matches regen semantic |
Yes |
Done |
…/worldgen-settings-recovery # Conflicts: # paper-server/patches/features/0004-Entity-Activation-Range-2.0.patch # paper-server/patches/features/0022-Remove-debug-like-logging.patch # paper-server/patches/features/0026-Optimise-collision-checking-in-player-move-packet-ha.patch # paper-server/patches/features/0027-Attempt-to-recalculate-regionfile-header-if-it-is-co.patch # paper-server/patches/features/0027-Optional-per-player-mob-spawns.patch # paper-server/patches/features/0028-Improve-cancelling-PreCreatureSpawnEvent-with-per-pl.patch # paper-server/patches/features/0029-DataConverter-Moonrise-co-fixes.patch
Upstream has released updates that appear to apply and compile correctly Paper Changes: PaperMC/Paper@e8a1f8fd Configurable plugin message channel limit PaperMC/Paper#14160 PaperMC/Paper@67912d08 [ci/skip] Re-enable using JBR for local run tasks again PaperMC/Paper#14318 PaperMC/Paper@02378ab5 Fire PrepareItemCraftEvent for Crafter preview PaperMC/Paper#14320 PaperMC/Paper@05c2798e Fix cancelled running scheduled task state PaperMC/Paper#14109 PaperMC/Paper@e3ba7b1d Regen missing worldgen settings file from server.properties PaperMC/Paper#14233
Closes #14066.
This PR fixes crash when the overworld
world_gen_settings.datis missing.Changes
Changed the recovery behavior, now will recover worldgen settings from server.properties instead of randomly picking seeds.
Tested these cases:
dimensions/data/overworlddirectoryworld_gen_settings.datin overworld dataDatapack settings will be merged in through
bake()below so worldgen datapacks still work