Repository navigation
Fire PrepareItemCraftEvent for Crafter preview - #14320
Conversation
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
This change is missing a comment, see the formatting section of the contributing docs, including the section regarding imports.
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
lgtm, I did notice that refreshRecipeResult is called quite a lot when opening a crafter menu due to it being called by the slotChanged method below. This would end up with a bit of event spam (~16 times during a single open), but don't think that should be a problem?
|
This PR does not fully fix the linked issue, as this one only looks at the crafter stuff. Maybe the linked issue should not be closed on merge before the furnace smelt stuff requested gets implemented. |
Would you prefer that I implement the furnace part in this PR too? or keep this PR focused on the Crafter and do the furnace part in another PR? |
|
I think a separate PR would be better so the changes are easier to review. |
Sounds good, I’ll do the furnace changes in a separate PR. |
papermc-projects
Bot
moved this from Changes required
to Delayed approval
in Paper PR Queue
papermc-projects
Bot
moved this from Delayed approval
to Full approval
in Paper PR Queue
github-project-automation
Bot
moved this from Full approval
to Merged
in Paper PR Queue
Upstream has released updates that appear to apply and compile correctly Paper Changes: PaperMC/Paper@e8a1f8fd Configurable plugin message channel limit PaperMC/Paper#14160 PaperMC/Paper@67912d08 [ci/skip] Re-enable using JBR for local run tasks again PaperMC/Paper#14318 PaperMC/Paper@02378ab5 Fire PrepareItemCraftEvent for Crafter preview PaperMC/Paper#14320 PaperMC/Paper@05c2798e Fix cancelled running scheduled task state PaperMC/Paper#14109 PaperMC/Paper@e3ba7b1d Regen missing worldgen settings file from server.properties PaperMC/Paper#14233
This makes PrepareItemCraftEvent fire when the Crafter updates its crafting preview, including when there is no valid recipe.
Partially addresses #12012