Fix slice selection bug in ChunkCachedArray - #2898
Closed
erikvansebille wants to merge 1 commit into
Closed
Conversation
Comment on lines
+143
to
+147
| # The chunk-cache fast path requires a fancy integer array per dimension. | ||
| # Some dims (e.g. unindexed extra dims) may come through as a bare slice | ||
| # instead, so fall back to dask's own vectorized indexing in that case. | ||
| if any(isinstance(k, slice) for k in key): | ||
| return self.array.vindex[key].compute() |
Contributor
There was a problem hiding this comment.
This completely bypasses the chunk caching mechanism and will degrade performance
Member
Author
There was a problem hiding this comment.
OK thanks; that's clear then. I'll close this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #2897 by supporting slice selection
Perhaps we should add some tests too?
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
I asked CoPilot how to fix the error shown in #2897; Claude then came with this solution that indeed fixed the error I encountered. However, I'm not entirely sure it's a full/valid solution, so I'd be keen to hear @VeckoTheGecko's feedback.