Repository navigation
Extend spatial slip condition to lower Z faces - #3044
Merged
Merged
Conversation
Extends `_Spatialslip` to apply free-slip and partial-slip conditions to fully non-wet lower faces normal to Z. The change now includes W in node classification (when available) and safely handles lateral W correction when lenZ == 1.
for more information, see https://pre-commit.ci
erikvansebille
requested changes
Nov 6, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
The code-change looks good! Could you also add some unit tests to e.g. the test_spatial_slip_interpolation function in tests/test_interpolation.py? So that we know that these changes (keep) working the way we expect them
Or would you prefer me to do that?
Contributor
Author
|
Thanks, Erik. I've added a test for the lower Z face, covering both free-slip and partial-slip. I'm not sure whether this is what you had in mind, but I've given it a try. If it isn't, would you mind adjusting it? |
erikvansebille
approved these changes
Nov 9, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Yep, the unit test looks good. Happy to approve this PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the function
_Spatialslipto apply free-slip and partial-slip conditions to fully non-wet lower faces normal to Z.The change now also includes W in node classification (if available) and safely handles lateral W correction when lenZ == 1 (even though it is a very rare case).