Fix duplicated socket parsing on item rebuild#2367
Draft
mcagnion wants to merge 1 commit into
Draft
Conversation
Avoid treating parsed Sockets and Rune lines as item modifier text so rebuilt pasted items do not gain duplicate sockets after Edit/Save.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Pasted game items with structured
Sockets:lines could rebuild with duplicate socket lines after an edit/save/reimport cycle.Item:ParseRawparsedSockets:andRune:spec lines into structured item fields, but those lines could also remain as modifier text and be emitted again byBuildRaw.This PR consumes those structured spec lines after parsing them, so socket and rune data is kept in the item fields without duplicating the original text line.
Steps taken to verify a working solution:
spec/System/TestItemParse_spec.luaforParseRaw -> BuildRaw -> ParseRawon a pasted item withSockets: S S; the rebuilt raw item keeps oneSockets:line and reparses to two sockets.busted ../spec/System/TestItemParse_spec.lua(65 passed)busted ../spec/System/TestItemsTab_spec.lua(53 passed)Sockets:modifier is gone, while the structured socket header remains.Before screenshot:
After screenshot: