Fix an interaction between Rakiatas Flow and sources of "ignore non-negative elemental resistances"#2373
Open
emptywalls wants to merge 1 commit into
Open
Conversation
…egative elemental resistances" Support for "ignore non-negative elemental resistances" was raised as [2] and implemented with [3], however the implementation did not address resistances inversion. As shown in [1], Rakiatas inversion is done before ignoring. [1] https://youtu.be/2d646c8_m0k?t=428 [2] PathOfBuildingCommunity#498 [3] PathOfBuildingCommunity#690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Support for "ignore non-negative elemental resistances" was raised as [2] and implemented with [3], however the implementation did not address resistances inversion. As shown in [1], Rakiatas inversion is done before ignoring.
[1] https://youtu.be/2d646c8_m0k?t=428
[2] #498
[3] #690
Steps taken to verify a working solution:
Have Ice Shot with Rakiatas, hover the "Heavy Frost" notable
Before: a dps decrease is shown
After: no change is shown
Have Ice Shot without Rakiatas, hover the "Heavy Frost" notable
Before: a dps increase is shown
After: the same dps increase is shown (no regression)