Skip to content

Fix Mana-Infused Staff zero-mana reservation state - #10305

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
mcagnion:fix/mana-infused-staff-reservation-breakdown
Oct 29, 2026
Merged

LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
mcagnion:fix/mana-infused-staff-reservation-breakdown

Conversation

@mcagnion

@mcagnion mcagnion commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Mana-Infused Staff is correctly disabled when Blood Magic leaves the character with no mana, but the disable decision introduced by #10283 happened after its forced mana percentage had already been added to the reservation aggregate and breakdown. This left a disabled skill represented as a 30% mana reservation during the zero-mana calculation pass.

This change moves the forced-mana availability check before reservation processing and strengthens the focused system test for the per-skill fields, player aggregate, final output, and Mana Reserved breakdown.

Steps taken to verify a working solution:

  • With a valid staff and Arrogance, Mana-Infused Staff remains enabled, reserves 30% of mana, and reserves no life.
  • When Blood Magic leaves the character with no mana, the skill is disabled without contributing to the reservation aggregate, final output, or Mana Reserved breakdown.
  • After switching from staff to non-staff and back, the reservation state and breakdown are cleared and rebuilt correctly.
  • The updated system regression test confirms that the disabled skill leaves no mana reservation aggregate, output, or breakdown entry.
  • The zero-mana result was also verified in the Windows UI.

The full suite was not run locally for this narrow follow-up. No UI layout or text is changed.

AI-assisted contribution disclosure: This change was developed and reviewed with OpenAI Codex and confirmed with focused automated tests and manual UI verification.

mcagnion and others added 2 commits August 28, 2026 21:51
Disable forced mana reservations before aggregation so a disabled Mana-Infused Staff cannot remain in reservation totals or breakdowns.

Follow-up to PR 10283.
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Oct 29, 2026
@LocalIdentity
LocalIdentity merged commit c995226 into PathOfBuildingCommunity:dev Oct 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants