Skip to content

Fix unique modifier parsing regressions from #9480 - #10397

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:codex/fix-unique-wording-regressions
Open

AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:codex/fix-unique-wording-regressions

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Several unique modifiers stopped working after the wording updates in #9480. The updated item text matches game data, but the parser still expects the older wording. This leaves modifiers unsupported and their effects missing from calculations.

This restores support for:

  • Painseeker's critical strike ailment drawback.
  • Scornflux's Arcane Surge cast-speed bonus applying to movement speed.
  • Gamblesprint's random movement-speed effect.
  • The Pariah's item rarity per white socket.
  • Triumvirate Authority's physical damage reduction bypass for socketed Vaal skills.
  • Hrimnor's Resolve's chill and freeze avoidance after using a Fire skill recently.

The changes extend the existing parser rules while preserving older wording for saved builds. The modifier cache is regenerated, and regression tests cover both wordings and the relevant conditions.

Steps taken to verify a working solution:

  • Confirmed the new regression cases fail before their respective fixes, then pass afterward.
  • Verified Painseeker still allows independent shock/freeze chance and doesn't change ignite's crit behavior.
  • Verified Scornflux's Arcane Surge condition
  • Verified Triumvirate Authority only affects Vaal skills socketed in the ring
  • Hrimnor's chill/freeze avoidance turns on and off if recently used Fire skill condition is enabled
  • Ran the full suite with the regenerated modifier cache: 596 successes, 0 failures, 0 errors.

Link to a build that showcases this PR:

https://pob.codes/b/WW63Y1zmAA0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant