Repository navigation
Fix unique modifier parsing regressions from #9480 - #10397
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Several unique modifiers stopped working after the wording updates in #9480. The updated item text matches game data, but the parser still expects the older wording. This leaves modifiers unsupported and their effects missing from calculations.
This restores support for:
The changes extend the existing parser rules while preserving older wording for saved builds. The modifier cache is regenerated, and regression tests cover both wordings and the relevant conditions.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pob.codes/b/WW63Y1zmAA0