Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10214
Description of the problem being solved:
If you have Wither or Exposure yourself and import a party that also has these effects, then both effects are applied, even tho they are local to the enemies so only the strongest effect should be active and not both.
Technically if both entities are able to apply wither, I am now using the 15 strongest stacks, so if a party import only applies e.g. 10 wither stacks with 50% increased effect and I have configured 15 withered stacks with 0% inc effect, it will automatically use the strongest 15 stacks which would be 10 stacks of 9% wither and then 5 stacks of 6% wither.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Carry: https://pob.codes/b/t0d6aoqYKuK
Partyguy: https://pob.codes/b/lMUV9zFxRtD
Carry with mixed wither import: https://pob.codes/b/KHjw76yqiSs
Before screenshot:
Double Exposure:

Double Wither:

After screenshot:
Strongest Exposure only:

Strongest Wither only:

Mixed Wither (10 from party @ 50% inc effect):
