Add Volatile Vaal Orb support#9935
Open
vaisest wants to merge 42 commits into
Open
Conversation
- adding a type hint for new() and newClass() - adding simple ---@Class x: y type hints for base class variables
… being an argument to newClass
…`) to fix type checking
…f using new() and varargs
vaisest
force-pushed
the
unique-scalability
branch
from
0ee18e7 to
bd3661f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9927, fixes #9875
Description of the problem being solved:
This ports PoE2 Vaal scaling support by mostly copy pasting @QuickStick123's code from e.g. PathOfBuildingCommunity/PathOfBuilding-PoE2#106 and other PRs
This also makes some small changes to that code, such as filtering mods by scalability. So e.g. Grants level # mods are not shown in the menu as they don't scale. The corrupted button hover also no longer uses db mode and now shows the properly scaled mod lines. I'll try to port these to PoB2.
Steps taken to verify a working solution:
The unscalable detection is not perfect. As noted in PathOfBuildingCommunity/PathOfBuilding-PoE2#113 and in my buy similar stat description stuff, there are problems with mods where PoB splits a single stat into two. This usually happens because a half of the stat isn't supported, and could be solved by parsing it in modparser despite it being unsupported. But this is obviously confusing to the user...
Based on #9861 for dev comfort, but rebaseable if necessary
Link to a build that showcases this PR:
Before screenshot:
After screenshot: