ci(docs): remove permanently red catalog freshness check - #10972
proggeramlug wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe documentation workflow now validates committed gettext catalogs with ChangesDocumentation workflow validation
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The workflow now validates committed catalogs and builds all translations without failing on harmless obsolete-entry reformatting, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on main in merge train 256 (#11018, v0.5.1638), main Carried at head Trains rebase-merge, so commits get new SHAs and GitHub cannot mark this PR merged. Closed as landed. |
Fixes #10955.
The Docs checks job regenerated every gettext catalog and required a byte-for-byte clean diff. This has been permanently red: gettext rewraps obsolete
#~entries, and the catalogs onmainalso contain active drift after a prior mass regeneration was reverted because it removed existing translations (43200e9d41). Filtering obsolete entries alone therefore cannot make this check pass. As the issue proposes, this removes the freshness gate while retainingmsgfmtsyntax/format validation and the English plus all-translations build. The job is renamed to match what it now checks.Validation:
msgfmt --check --check-format --statisticspasses for all ten.pocatalogs.PATH=/tmp/perry-mdbook-054:$PATH ./docs/i18n.sh build-allbuilds English and all ten translations with mdBook v0.5.4 and mdbook-i18n-helpers v0.4.0.git diff --checkpasses.build-and-validationpassed on the PR head: https://github.com/PerryTS/perry/actions/runs/35726226687