Fix macOS app bundle icon and metadata fallbacks - #10983
proggeramlug wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on main in merge train 256 (#11018, v0.5.1638), main Carried at head Trains rebase-merge, so commits get new SHAs and GitHub cannot mark this PR merged. Closed as landed. |
Summary
assets/AppIcon.icnsto the macOS app bundle'sContents/Resources/root and setCFBundleIconFilein the embedded and external plists.[project].namefor the app display name when no display name is configured, and usepackage.json's version when[project].versionis absent.Fixes #10847.
Verification
cargo test -p perry --bin perry macos_version_uses_package_json_when_project_version_is_missingcargo test -p perry --test macos_app_bundle(with matching local archives inPERRY_RUNTIME_DIR)rustfmt --check,git diff --check, andscripts/check_file_size.sh