fix(benchmarks): fingerprint all Cargo inputs except workspace release version (#10977) + release v0.5.1637 - #11017
Merged
Merged
Conversation
added 2 commits
September 22, 2026 16:52
…e version (#10977) Replaces the profile-only Cargo.toml extraction with whole-root-manifest hashing that normalizes only the single-line [workspace.package].version value, so dependency, feature, member and edition changes invalidate the published benchmark evidence again while a release bump does not. Scoped to that table, so dependency-table `version` fields stay significant.
|
Warning Review limit reachedNext included review available in 10 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #10977's content on current main, as the owner approved. The original branch bumps 1635 → 1636 and main is already at 1636, so the release bump is rebuilt here rather than merged.
Content (unchanged from #10977
689b1ffbab):benchmarks/public_baseline.py,tests/test_public_baseline.pyand the changelog fragment. None of the three has moved on main since that branch's base.Not included: #10977's regenerated artifact commit (
915fe7cece). It goes stale the moment #10354 lands, under this PR's own scheme: it records source fingerprintbb679718…, and the post-#10354 tree hashes to9c87723d…, because #10354 adds workspace members and dependencies to the rootCargo.tomland this change now hashes those. It is also stale in substance, having measured the tokio event loop #10354 replaces. One regeneration follows on main afterwards.Verification on this exact tree:
tests/test_public_baseline.py: 15 OK.tests/test_benchmark_gate.py: 30 OK.bb679718…/513dba8f…). The landing refuses if they differ.versionlines inCargo.lock, and no registry dependency moved backwards.The public-baseline lint step stays red until the regeneration; this change does not relabel old measurements as fresh.
No close keyword: #10980 is the lockfile-downgrade issue, which #10982 fixes. This PR carries no issue reference of its own.