test(gc): run remembered coverage sabotage in release - #11027
proggeramlug wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe GC remembered-set coverage cross-check now compiles in test builds, including release tests. The sabotage test no longer skips release configurations. Supporting names, comments, and the changelog describe this coverage. ChangesGC release test coverage
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The release sabotage witness is connected to the intended cross-check without changing production release behavior, so the change is mergeable. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on main in merge train 257 (#11039, v0.5.1640), main Carried at head This train was split by blast radius after an earlier 35-PR assembly hit five gap regressions: it carries only PRs touching no lowering path. Trains rebase-merge, so commits get new SHAs and GitHub cannot mark this merged. Closed as landed. |
Summary
Run the remembered-set coverage sabotage witness in release unit-test builds instead of silently ignoring it. The cross-check remains compiled out of production release binaries.
Changes
cfg(test)as well asdebug_assertionsRelated issue
Fixes #10604
Test plan
RUST_TEST_THREADS=1 LLVM_SYS_221_PREFIX=/usr/lib/llvm-22 cargo test --release -p perry-runtime --lib gc::tests::copy_slot_decode::sabotaged_remembering_arm_is_refused_by_the_coverage_cross_check -- --exact --nocapture(1 passed, 0 ignored; expected sabotage assertion observed)RUST_TEST_THREADS=1 LLVM_SYS_221_PREFIX=/usr/lib/llvm-22 cargo test --release -p perry-runtime --lib(4,277 passed; 5 ignored)perrymaster.skelpo.netcargo fmt --all -- --checkpython3 scripts/check_test_registration.pyscripts/check_file_size.shChecklist
feat:/fix:/docs:/chore:prefix convention used in the logSummary by CodeRabbit
cargo test --release.