ci: skip parity aggregate when parity is skipped

[proggeramlug]

Fixes #10390.

What changed

• Require the parity dependency to have actually run before starting parity-aggregate.
• Preserve aggregation when parity succeeds or fails, so failed-shard reports still reach the aggregate diagnostics.
• Skip the aggregate when an upstream failure caused parity itself to be skipped.

Validation

• python3 scripts/ci_plan.py --self-test
• python3 scripts/gc_gate_wiring_check.py --self-test
• python3 scripts/gc_gate_wiring_check.py
• Parsed test.yml with PyYAML and verified every job-level !cancelled() gate also checks a dependency result.
• actionlint has the same four pre-existing shellcheck findings as upstream/main; this change adds none.
• git diff --check

Summary by CodeRabbit

• Bug Fixes
  • The parity aggregate job now collects reports when parity checks run and fail, but skips when they are prevented from running by an upstream failure or are skipped.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0a5ae5b1-9a61-4ff8-a418-2516c9b5e3a9

📥 Commits

Reviewing files that changed from the base of the PR and between f5cfbff and 11769af.

📒 Files selected for processing (2)

• .github/workflows/test.yml
• changelog.d/11050-parity-aggregate-needs.md

Included review availability: Your plan provides up to 8 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The parity aggregate job now runs only when parity is enabled, the parity job completed with success or failure, and the workflow was not cancelled. A changelog entry documents this condition.

Changes

Parity aggregate condition

Layer / File(s)	Summary
Gate aggregation on parity result .github/workflows/test.yml, changelog.d/11050-parity-aggregate-needs.md	The job condition requires parity to be enabled and the parity job result to be success or failure, while still excluding cancelled runs. The changelog records that the aggregate skips if upstream failure prevents parity from running.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 11769

The aggregate skips when parity did not run while retaining reports when parity shards fail. No actionable merge risk was identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	For [#10390], the PR summary confirms that parity-aggregate runs when needs.parity.result is success or failure, and skips when parity is skipped. This meets the main fix while preserving fail…	Provide reviewable evidence that the other bare !cancelled() gates in test.yml were audited and are deliberate, or provide the remaining workflow content needed to assess them.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: skip the parity aggregate when the parity job is skipped.
Description check	✅ Passed	The description explains the change, identifies related issue #10390, and lists validation steps. The template’s checklist is not included, but the description is otherwise mostly complete.
Out of Scope Changes check	✅ Passed	The workflow change and changelog entry both address [#10390]. No unrelated changes appear in the PR summary.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Full details: Linked Issues check

Explanation

For [#10390], the PR summary confirms that parity-aggregate runs when needs.parity.result is success or failure, and skips when parity is skipped. This meets the main fix while preserving failed-shard aggregation. The issue also asks for an audit of other bare !cancelled() gates. The available summary does not report the audit results, and the workflow read was truncated before the relevant remaining jobs.

✨ Finishing Touches 💡 1

🧪 Generate unit tests (beta)

• Create a new PR

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[proggeramlug]

Landed on main in merge train 259 (#11079), released as v0.5.1642 at 7f4417b5a1.

Your commits are on main — cherry-picked from this PR's head 11769af31e and validated as one tree, CI 22/22 green including all 6 gap-suite shards. GitHub cannot auto-close a PR whose commits land under new SHAs via a train rebase, which is why I'm closing this by hand rather than it happening on merge.

Nothing is lost and nothing is needed from you. Thanks.