test(inline): cover class expression evaluation-owner remapping - #11222
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change adds substitution tests for fresh class evaluation owners and a TypeScript regression test for repeated class-factory calls. The changelog entry records this coverage. ChangesFresh class owner remapping
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The new tests exercise the reported self-binding regression. No issue requiring a fix before merge was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge queue: this now conflicts with main in |
bfd767c to
c44076f
Compare
Closes #11154.
A named class-expression factory used to lose its self-binding when inlined: captures were remapped to the caller's locals, but
ClassExprFresh.evaluation_ownerretained the callee's local. A static block readingC.prototypethen threw onundefined.The production fix has now landed on main through #11142 (aec71db). This PR adds dedicated regression coverage without changing that implementation:
Validation after rebasing onto main ba9adf1:
No version bump. The changelog fragment is keyed to this PR.
Summary by CodeRabbit