Release: never abort the publish step over a missing release note - #41
Merged
Merged
Conversation
The alpha.4 publish (run 35007316294) uploaded all 12 crates, created one
tag, then failed: 'No changelog entry for turnloop-io-v0.1.0-alpha.4'. A
workspace release bumps every crate, but release-plz writes a section only for
the crates whose own sources changed, so eleven crates were published without
tags or GitHub releases.
The requirement now runs in preflight, where it can still block a release
before anything is uploaded. In the publish step a version-only bump gets an
explicit body ('No crate-specific changes; released with the workspace')
instead of stopping a live publish half-way. A missing CHANGELOG.md file
remains a hard failure in both places.
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alpha.4 publish (run 35007316294) uploaded all 12 crates, created one tag, then failed:
A workspace release bumps every crate, but release-plz writes a changelog section only for the crates whose own sources changed. So eleven crates are on crates.io at 0.1.0-alpha.4 with no tag and no GitHub release, and the step failed at the worst possible point — after the irreversible part.
No crate-specific changes; released with the workspace) rather than aborting a live publish.CHANGELOG.mdfile remains a hard failure in both places.I will create the eleven missing alpha.4 tags and releases separately.