Stop engagement-count store errors from zeroing For You rank features - #63
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop engagement-count store errors from zeroing For You rank features#63Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Dragonfly Err was coerced to an empty map, then Ok(default) counts. CachedHydrator cached those zeros for 60s and Phoenix unwrap_or(0) ranked the slate as if nobody engaged. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragonfly Err in EngagementCountsHydrator was coerced to an empty HashMap. Every candidate then got Ok(CachedCounts::default()). CachedHydrator caches Ok for 60s. as_tweet_info unwrap_or(0) stamps Phoenix InputBuffer and Thompson sampling as if the post had no favs, replies, or views.
Proof
This is not xai-org#171/xai-org#177 (notes). Not xai-org#172 (author diversity retweeter key). Not xai-org#173 (safemodel). Not xai-org#174 (UserCred). Not xai-org#175/xai-org#176 (cache mutual-follow / Phoenix rescore). Not xai-org#142 (empty Phoenix heads). Not #22 (cold-start thresholds). Not #21 (DPP missing embeddings).
Fix: on client Err, return Err for candidates that need a fetch. CachedHydrator does not insert. update_all leaves existing counts. Successful per-id misses stay Ok(default), same as a tweet with no row.
Tests cover store Err (no zero stamp), no cache poison, cached-post ineligible preserve, and successful miss unchanged.
cargo test cannot run here. Public dump has no Home Mixer manifest. Standalone rustc model of the stamp path passed 4/4.