Stop Thunder from burying undeleted in-network posts - #68
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop Thunder from burying undeleted in-network posts#68Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
TweetUndeleteEvent was dropped on the feeder, and insert_posts refused tombstoned ids, so a restored tweet stayed off For You until retention trim. Handle undelete like create and clear the tombstone on re-insert. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Thunder delete has a handler. Thunder undelete does not. A restored followee tweet stays off For You until the tombstone ages out.
Five-line proof
TweetDeleteEventremoves the CompactPost and insertspost_idintodeleted_posts.TweetUndeleteEventwith the same tweet/user payload as create._ => {}, so noInNetworkEventwas emitted.insert_postsrefused any later create for a tombstoned id (if deleted_posts.contains_key { continue }).GetInNetworkPoststherefore omitted the restored tweet for up to the retention window.Twin: delete is handled; undelete is not. This is not xai-org#138 (QuotedTweetDelete kills the quote) and not xai-org#150 (RT of a tombstoned original).
Fix
TweetUndeleteEventthrough the same LightPost builder as create (nullcast still skipped) and emitsTweetCreateEvent.Tests
undelete_clears_tombstone_and_restores_post(fails on unmodified main)cargo: cannot run. Public dump has no Thunder manifest.
Rejection table (this wave)