Stop MoE corpus from keying the retweeter - #70
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
AuthorColdStart gated Phoenix MoE scores on wrapper author_id. Retweets of a treatment origin by an unbucketed retweeter were zeroed; retweets of a control origin by a treatment retweeter leaked. Key the original author, matching Phoenix tweet_info. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
AuthorColdStart::author_corpusgated Phoenix MoE scores on wrapperauthor_id. Phoenix already keys the original author (as_tweet_info/get_original_author_id). A treatment-origin retweet by an unbucketed retweeter was zeroed. A control-origin retweet by a treatment retweeter leaked into treatment For You.This is not xai-org#172 (RankingScorer author-diversity pool). This is not #31 / author-size IPS. This is not xai-org#125 (gizmoduck origin size/NSFW). Diversity stays the post-Phoenix repeat lever. Corpus membership is the MoE keep/zero gate.
Five-line proof
ForYouPhoenixRetrievalMoe; CoreData writesretweeted_user_idfrom TESsource_user_id.author_corpus->apply_moe_ranking_policy->RankingScorer/VMRanker->TopKScoreSelector.c.author_id(retweeter).get_original_author_id()was unused.PostCandidate::as_tweet_infoalready sends the original author to Phoenix. Cold-start boost already excludes RTs (retweeted_tweet_id.is_none()).Fix
Key
AuthorIsTreatment/AuthorIsControlonget_original_author_id(). Originals and quotes unchanged.Tests
treatment_keeps_moe_retweet_of_treatment_origin(fails on unmodified main)treatment_zeros_moe_retweet_of_control_origin(fails on unmodified main)Standalone rustc model of old vs new corpus: 3/3 passed (2 fail on unmodified main).
cargo: cannot run. Public dump has no home-mixer Cargo.toml.
Rejection table (this wave)