Stop SubscriptionHydrator from skipping exclusive ids on quotes - #72
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop SubscriptionHydrator from skipping exclusive ids on quotes#72Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Phoenix TES exclusive lookup keyed only the quote wrapper tweet_id. Super Follow lives on the quoted original, so IneligibleSubscriptionFilter kept the card as public. Fetch the quoted id and use it when the wrapper is not exclusive. Retweet originals stay xai-org#155. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phoenix SubscriptionHydrator asks TES for exclusive authors by wrapper tweet_id. Super Follow lives on the quoted original. A quote wrapper is not exclusive, so subscription_author_id stays None and IneligibleSubscriptionFilter keeps the card.
xai-org#155 keys retweet originals via get_original_tweet_id(). That helper is retweeted_tweet_id.unwrap_or(tweet_id). Quotes keep the wrapper id. This is the leftover quoted exclusive TES key.
This is not xai-org#155 (retweet original). This is not xai-org#118 (quoted id hydration). This is not xai-org#129 (subscription-list miss). This is not xai-org#141 (TES exclusive fail-closed).
This is not xai-org#184 (ads served history). This is not xai-org#157 (Explore topic hydration). This is not xai-org#170 (rank-all NSFW index). This is not xai-org#146 (soft VF Avoid/Tombstone/Interstitial).
Proof:
Fix: Fetch TES exclusive authors for tweet_id and quoted_tweet_id. Use the wrapper author when the quote itself is exclusive. Use the quoted author when the wrapper is not exclusive and the quoted original is. Retweet originals stay xai-org#155.
Fork PR: none. Survey: xai-org#96-xai-org#188. Unclaimed.