Stop Phoenix authorIsNsfwSeq from skipping retweets - #73
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop Phoenix authorIsNsfwSeq from skipping retweets#73Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
as_tweet_info zeroed safety_label_mask on every retweet, so Phoenix hashed the origin author with authorIsNsfwSeq=0. Gizmoduck already fetched the origin user but wrote the retweeter's NSFW bit. Stamp nsfw_author_phoenix from the origin on retweets and drop the retweet skip in as_tweet_info. Filter/ads poster bits are unchanged. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phoenix hashes
get_original_author_id()butas_tweet_infozeroedsafety_label_maskon every retweet. Gizmoduck already fetched the origin user and then wrote the retweeter's NSFW bit intonsfw_author_phoenix. Training readssafetyLabelMaskSeqbit 2; serving therefore scored every RT of an NSFW original as a clean-author post.Proof
This is not xai-org#125 (size residual, quoted OR, gizmoduck fail-closed). Not xai-org#185 (OON NSFW pre-score filter). Not xai-org#172/xai-org#188 (diversity/MoE retweeter key). Not xai-org#173 (safemodel tweet labels). Not xai-org#189 (DedupConversationFilter). Filter and ads poster bits are unchanged.
Fix
Tests cover origin-NSFW RT stamp, retweeter-NSFW clean-origin no stamp, and original-post unchanged.
cargo test cannot run home-mixer. Public dump has no Home Mixer manifest. Standalone rustc model of old vs new stamp: 5/5 passed.
Fork PR: none