Skip to content

feat(admin): remove the Elasticsearch reindex/backfill cards (PPT-2644) - #308

Merged
camreeves merged 3 commits into
developfrom
PPT-2644-remove-reindex-ui
Aug 13, 2026
Merged

feat(admin): remove the Elasticsearch reindex/backfill cards (PPT-2644)#308
camreeves merged 3 commits into
developfrom
PPT-2644-remove-reindex-ui

Conversation

@camreeves

@camreeves camreeves commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Part of PPT-2644: PlaceOS search is now served directly from PostgreSQL full-text search (models #324/#325, rest-api #445 — merged and live). There is no Elasticsearch index left to rebuild, so the admin reindex/backfill controls are dead UI.

What

  • Removes the two Database admin cards (reindex + backfill), their click handlers, progress signals and the POST /reindex / POST /backfill helpers from database-details.component.ts. The Zone tree export/import cards on the same page are unchanged.
  • Drops the orphaned ADMIN.DATABASE_REINDEX* / ADMIN.DATABASE_BACKFILL* locale keys across all 7 locale files.
  • Rewords the splitZoneSystems doc comment in cascade-delete.ts that justified its re-read step with "the index is Elasticsearch backed". The re-read through showSystem stays — concurrent edits can still race the zone walk, and older backends still serve listings from a lagging index during rollout — only the rationale is updated.
  • Drops the now-unused TranslatePipe / apiEndpoint / post imports the card removal orphaned (was warning NG8113 in the production build).

Verification

  • tsc --noEmit -p tsconfig.app.json exits clean on the branch.
  • Production build green on this branch (it surfaced the NG8113 unused-import warning that the final commit removes).
  • grep -riE 'elasticsearch|search-ingest|neuroplastic|reindex|backfill' over src/ and public/assets/locale/ returns nothing — no ES-era references remain.

Merge order

Timing is flexible relative to the other PPT-2644 infra-removal PRs: the server keeps /reindex and /backfill as deprecated 200 no-ops, so both the old UI against the new backend and this UI against any backend work fine.

camreeves and others added 3 commits August 10, 2026 21:43
Search is served directly from PostgreSQL; the endpoints are no-ops
server-side pending removal. Zone tree export/import cards unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ationale (PPT-2644)

Search is served from PostgreSQL; the re-read through showSystem stays,
because concurrent edits can still race the zone walk and older backends
still serve a lagging index during rollout.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tails (PPT-2644)

Removing the reindex/backfill cards left no translate pipe usage in the
template, so the production build warned NG8113. Import list reformatted
by prettier's organize-imports on the way through.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
backoffice Ready Ready Preview Aug 13, 2026 1:38am

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown

Greptile Summary

Removes obsolete Elasticsearch reindex and backfill controls now that search is served by PostgreSQL.

  • Removes the admin cards, request helpers, handlers, progress state, and unused imports.
  • Removes the associated translation keys from all supported locales.
  • Updates the cascade-delete comment while preserving its defensive re-read behavior.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The obsolete UI, its private handlers, request helpers, and translations are removed consistently, while the remaining database administration behavior and cascade-delete runtime logic are unchanged.

Important Files Changed

Filename Overview
src/app/admin/database-details.component.ts Cleanly removes the obsolete controls and their now-unused implementation without affecting the remaining zone import/export features.
src/app/common/cascade-delete.ts Rewords documentation to reflect current and transitional stale-listing scenarios without changing runtime behavior.
public/assets/locale/ar.json Removes only the four orphaned reindex/backfill translations.
public/assets/locale/en-AU.json Removes the orphaned translations; the additional changed lines are whitespace-only cleanup.
public/assets/locale/en-GB.json Removes the orphaned translations; the additional changed lines are whitespace-only cleanup.
public/assets/locale/en-US.json Removes the orphaned translations; the additional changed lines are whitespace-only cleanup.
public/assets/locale/es.json Removes only the four orphaned reindex/backfill translations.
public/assets/locale/fr.json Removes only the four orphaned reindex/backfill translations.
public/assets/locale/jp.json Removes the orphaned translations; the additional changed lines are whitespace-only cleanup.

Reviews (1): Last reviewed commit: "fix(admin): drop the now-unused Translat..." | Re-trigger Greptile

@camreeves
camreeves merged commit 74f44e7 into develop Aug 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant