feat(admin): remove the Elasticsearch reindex/backfill cards (PPT-2644) - #308
Merged
Conversation
Search is served directly from PostgreSQL; the endpoints are no-ops server-side pending removal. Zone tree export/import cards unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ationale (PPT-2644) Search is served from PostgreSQL; the re-read through showSystem stays, because concurrent edits can still race the zone walk and older backends still serve a lagging index during rollout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tails (PPT-2644) Removing the reindex/backfill cards left no translate pipe usage in the template, so the production build warned NG8113. Import list reformatted by prettier's organize-imports on the way through. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryRemoves obsolete Elasticsearch reindex and backfill controls now that search is served by PostgreSQL.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The obsolete UI, its private handlers, request helpers, and translations are removed consistently, while the remaining database administration behavior and cascade-delete runtime logic are unchanged.
|
| Filename | Overview |
|---|---|
| src/app/admin/database-details.component.ts | Cleanly removes the obsolete controls and their now-unused implementation without affecting the remaining zone import/export features. |
| src/app/common/cascade-delete.ts | Rewords documentation to reflect current and transitional stale-listing scenarios without changing runtime behavior. |
| public/assets/locale/ar.json | Removes only the four orphaned reindex/backfill translations. |
| public/assets/locale/en-AU.json | Removes the orphaned translations; the additional changed lines are whitespace-only cleanup. |
| public/assets/locale/en-GB.json | Removes the orphaned translations; the additional changed lines are whitespace-only cleanup. |
| public/assets/locale/en-US.json | Removes the orphaned translations; the additional changed lines are whitespace-only cleanup. |
| public/assets/locale/es.json | Removes only the four orphaned reindex/backfill translations. |
| public/assets/locale/fr.json | Removes only the four orphaned reindex/backfill translations. |
| public/assets/locale/jp.json | Removes the orphaned translations; the additional changed lines are whitespace-only cleanup. |
Reviews (1): Last reviewed commit: "fix(admin): drop the now-unused Translat..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PPT-2644: PlaceOS search is now served directly from PostgreSQL full-text search (models #324/#325, rest-api #445 — merged and live). There is no Elasticsearch index left to rebuild, so the admin reindex/backfill controls are dead UI.
What
POST /reindex/POST /backfillhelpers fromdatabase-details.component.ts. The Zone tree export/import cards on the same page are unchanged.ADMIN.DATABASE_REINDEX*/ADMIN.DATABASE_BACKFILL*locale keys across all 7 locale files.splitZoneSystemsdoc comment incascade-delete.tsthat justified its re-read step with "the index is Elasticsearch backed". The re-read throughshowSystemstays — concurrent edits can still race the zone walk, and older backends still serve listings from a lagging index during rollout — only the rationale is updated.TranslatePipe/apiEndpoint/postimports the card removal orphaned (was warning NG8113 in the production build).Verification
tsc --noEmit -p tsconfig.app.jsonexits clean on the branch.grep -riE 'elasticsearch|search-ingest|neuroplastic|reindex|backfill'oversrc/andpublic/assets/locale/returns nothing — no ES-era references remain.Merge order
Timing is flexible relative to the other PPT-2644 infra-removal PRs: the server keeps
/reindexand/backfillas deprecated 200 no-ops, so both the old UI against the new backend and this UI against any backend work fine.