Conversation
- Elekid (Route 205, Valley Windworks): rarity 4% -> 8% per slot - Magby (Route 227, Stark Mountain exterior/interior): rarity 4% -> 8% per slot - Added dedicated encounter slots (9001-9004) to avoid affecting shared slots - Sources: Bulbapedia
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
This PR fixes the encounter rarity values for Elekid (#239) and Magby (#240) in Pokémon Diamond and Pearl (version IDs 12 and 13).
Problem
Both Pokémon currently use encounter slots 9 and 10 (
encounter_slots.csv), which have a rarity of 4% each. These slots are shared with Buizel (#418) and Shellos (#422) in the affected areas, so modifying them directly would have incorrectly changed the encounter rates of those Pokémon as well.Solution
Four dedicated encounter slots were added to
encounter_slots.csvwith a rarity of 8%:9001(slot 13) and9002(slot 14) for Elekid9003(slot 15) and9004(slot 16) for MagbyThe corresponding rows in
encounters.csvwere updated to point to these new slots:Sources
Contributor check list