Skip to content

feat(auth): add privacy links, compact dev sign-in, and redesign roles page - #59

Merged
lorenzocorallo merged 4 commits into
mainfrom
feature/auth-privacy-dev-signin
Oct 15, 2026
Merged

feat(auth): add privacy links, compact dev sign-in, and redesign roles page#59
lorenzocorallo merged 4 commits into
mainfrom
feature/auth-privacy-dev-signin

Conversation

@lorenzocorallo

@lorenzocorallo lorenzocorallo commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Login and footer

  • Add Privacy Policy links to the login flow and a shared footer with PoliNetwork links.
  • Collapse the development sign-in panel into an expandable control and simplify persona descriptions.
  • Adjust the login layout to fit the shared footer.
  • Keep the footer at the bottom of short pages: page shells used min-h-screen, which pushed the footer below the viewport even when the content was short.

eRBACo roles page (from the Figma design)

  • Built-in roles are now icon cards; created roles are compact rows with member and permission counts.
  • The search box (now a reusable SearchField) sits under "Created" and filters only created roles. The built-in roles explanation moved into a tooltip.
  • Icons are lucide glyphs drawn at the Figma line widths (src/components/rbac/icons.tsx). Socio and Direttivo use the white PoliNetwork mark from Figma in dark mode and the full-colour logo in light mode.

Screenshots

Roles page

Dark Light
Roles page, dark Roles page, light

Login page with Privacy Policy link and footer

Dark Light
Login, dark Login, light

Dev sign-in expanded

Dark Light
Dev sign-in open, dark Dev sign-in open, light

Testing

  • vp test: 296 passed, 114 skipped.
  • Lint and tsc --noEmit pass. vp check reports a formatting issue in src/dev/personas.ts, which this PR changes.
  • Checked the roles page, the login page, and footer placement in the running app in both themes.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9cb12826-a9db-4833-9f25-6f096a3dc80c
📥 Commits

Reviewing files that changed from the base of the PR and between 7f69397 and aaa3232.

⛔ Files ignored due to path filters: 1
  • public/brands/polinetwork-mono.svg is excluded by !**/*.svg
📒 Files selected for processing: 10
  • src/components/dev-login.tsx
  • src/components/login-page.tsx
  • src/components/rbac/catalog-search.tsx
  • src/components/rbac/icons.tsx
  • src/components/route-error.tsx
  • src/dev/personas.ts
  • src/routes/__root.tsx
  • src/routes/access/roles/index.tsx
  • src/routes/index.tsx
  • src/styles.css

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8efc1094-38c0-4fa9-8806-a67e08d4779d
📥 Commits

Reviewing files that changed from the base of the PR and between e144167 and 7f69397.

📒 Files selected for processing: 5
  • src/components/dev-login.tsx
  • src/components/login-page.tsx
  • src/dev/personas.ts
  • src/routes/__root.tsx
  • src/styles.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The development persona panel is now collapsible and displays updated descriptions. The login page now shows a privacy-policy acknowledgment. The application shell adds a footer with links to the PoliNetwork website and privacy policy, which is hidden on the login page.

Changes

Development persona panel

Layer / File(s) Summary
Collapsible persona panel
src/components/dev-login.tsx, src/dev/personas.ts		 The panel starts closed and uses an accessible toggle to reveal persona links. Persona descriptions change, while warning logic remains unchanged.

Login layout and footer

Layer / File(s) Summary
Login layout and privacy links
src/routes/__root.tsx, src/components/login-page.tsx, src/styles.css		 The application shell adds website and privacy-policy links in its footer. The login page replaces its prior footer text with a privacy-policy acknowledgment, and CSS hides the application footer on that page.

Priority: ⬇️ Low

Change: Feature

Merge Risk: ⚪ Minimal · up to 7f693

No actionable issue currently blocks the login interface update; run the normal checks before merging.

Pre-merge checks: Passed 2 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check Warning The title accurately mentions privacy links and compact development sign-in, but it also claims a redesign of the roles page. The changeset does not include a roles page redesign. Remove the unrelated phrase and use a title such as "feat(auth): add privacy links and compact dev sign-in".
Passed Passed checks: 2 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

lorenzocorallo and others added 2 commits October 15, 2026 13:43
@lorenzocorallo
feat(roles): redesign role catalog cards
de09be2 
- Separate built-in roles into icon cards and created roles into compact rows
- Add reusable search field and role catalog icons
@lorenzocorallo @claude
fix(layout): keep the footer at the bottom of short pages
3f8145b 
Page shells used min-h-screen, so their content alone filled the viewport
and pushed the footer below it. They now fill the space the root layout
leaves instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lorenzocorallo lorenzocorallo changed the title Add privacy links and compact dev sign-in feat(auth): add privacy links, compact dev sign-in, and redesign roles page Oct 15, 2026
@lorenzocorallo
lorenzocorallo merged commit 8045a57 into main Oct 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lorenzocorallo