Repository navigation
fix(auth): send signers' directory email, never the sign-in placeholder - #64
Merged
Merged
Conversation
PoliNetwork and Telegram accounts store a placeholder address, so the e-signing directory showed and saved pn-entra.<id>@identity.invalid. It now sends the address administrators see (PoliNetwork first), or null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/internal/esign-usersreturned the rawuser.email, which for PoliNetwork (Entra) and Telegram sign-ins is the placeholder<provider>.<id>@identity.invalid. The signing picker showed it, and backend#79 saved it as the address signature requests are emailed to.contactEmails: the linked @polinetwork.org address first), or null.contactEmailsgains aneveryonescope that reads all accounts in one query, without one parameter per user.Verification
tsc --noEmit,vp test(305 passed),vp check,pnpm run build.email: nullfor a placeholder) needs the integration database and was skipped.Rollout
Deploy with or before PoliNetworkOrg/backend's matching fix; no contract change.
🤖 Generated with Claude Code