Skip to content

fix(auth): send signers' directory email, never the sign-in placeholder - #64

Merged
lorenzocorallo merged 1 commit into
mainfrom
fix/esign-users-real-names
Oct 17, 2026
Merged

lorenzocorallo merged 1 commit into
mainfrom
fix/esign-users-real-names

Conversation

@lorenzocorallo

Copy link
Copy Markdown
Member

Summary

  • /api/internal/esign-users returned the raw user.email, which for PoliNetwork (Entra) and Telegram sign-ins is the placeholder <provider>.<id>@identity.invalid. The signing picker showed it, and backend#79 saved it as the address signature requests are emailed to.
  • It now returns the address administrators see in the user directory (contactEmails: the linked @polinetwork.org address first), or null.
  • contactEmails gains an everyone scope that reads all accounts in one query, without one parameter per user.

Verification

  • tsc --noEmit, vp test (305 passed), vp check, pnpm run build.
  • The HTTP integration test (updated to expect email: null for a placeholder) needs the integration database and was skipped.

Rollout

Deploy with or before PoliNetworkOrg/backend's matching fix; no contract change.

🤖 Generated with Claude Code

PoliNetwork and Telegram accounts store a placeholder address, so the e-signing directory showed and saved pn-entra.<id>@identity.invalid. It now sends the address administrators see (PoliNetwork first), or null.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4d6fd23f-e442-4461-9548-ffba4ba2a8d2
📥 Commits

Reviewing files that changed from the base of the PR and between f013796 and 9d03d03.

📒 Files selected for processing: 3
  • src/auth/access-snapshot.integration.test.ts
  • src/auth/contact-email.ts
  • src/routes/api/internal/esign-users.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lorenzocorallo
lorenzocorallo merged commit 10aa036 into main Oct 17, 2026
2 checks passed
@lorenzocorallo
lorenzocorallo deleted the fix/esign-users-real-names branch October 17, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant