Skip to content

fix(esign): list registered eligible signers before first visit - #79

Merged
lorenzocorallo merged 1 commit into
mainfrom
fix/esign-directory-signers
Oct 17, 2026
Merged

lorenzocorallo merged 1 commit into
mainfrom
fix/esign-directory-signers

Conversation

@lorenzocorallo

Copy link
Copy Markdown
Member

Summary

  • Load registered users from the IdP for signer selection, including users without a signing profile.
  • Apply esign:sign and each selected drive's sign rule before listing or accepting a signer.
  • Sync a selected user's signing profile when creating the request, so the first signature request and email work without a prior visit.

Verification

  • bun run check
  • bun run typecheck
  • bun run test (124 passed, 8 skipped)
  • bun run build
  • bun run build:npm

Rollout

Depends on PoliNetworkOrg/auth#63. Deploy auth first so the registered-user endpoint exists before this backend starts using it. A focused regression test covers a registered signer who has never opened Signatures.

Read registered identities from the IdP, apply current signing permissions and drive rules, and sync selected signer profiles when creating a request.
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 14dc7b9f-cb12-4535-b94d-ba1c769edd03
📥 Commits

Reviewing files that changed from the base of the PR and between 05deb03 and 71347b3.

📒 Files selected for processing: 4
  • src/esign/index.ts
  • src/esign/service.ts
  • src/idp/index.ts
  • tests/esign-service.test.ts
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lorenzocorallo
lorenzocorallo marked this pull request as ready for review October 17, 2026 16:06
@lorenzocorallo
lorenzocorallo merged commit 71d501c into main Oct 17, 2026
2 checks passed
@lorenzocorallo
lorenzocorallo deleted the fix/esign-directory-signers branch October 17, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant