Repository navigation
Say what the ESI registry receipt's cleanliness check covers (#454) - #1379
Merged
Merged
Conversation
Round 8's review of microcosm#1189 found the COMPILER_PATHS comment in compare_registries.py overstated: it said the paths were everything the compiled registry depends on besides the two feeds, but the script's own target period and serialization and uv.lock also shape the registry and its digests and are not checked. The comment now says so. Code and the committed receipt are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Merged at reviewed head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to microcosm#1189. Round 8's executed review (GPT-6.1 Sol, APPROVE WITH NITS) left one nit, about a code comment.
COMPILER_PATHSinexperiments/us-esi-454/feed-repin/compare_registries.pywas described as "everything the compiled registry depends on besides the two feeds". That overstates it. The receipt'ssources_cleancheck covers onlypackages/andtools/. The script's own target period and serialization, anduv.lock, also shape the registry and its digests, and they are not checked. The comment now says what is checked and what is not.This is a comment-only change. No code or receipt changes, and
registry_diff.jsonstays as committed (round 8 reproduced it).axiom: n/a: data pipeline
🤖 Generated with Claude Code