Skip to content

Keep staging candidate tests on the deployment runner - #3870

Merged
anth-volk merged 2 commits into
masterfrom
fix/staging-candidate-integrated-qualification
Oct 8, 2026
Merged

anth-volk merged 2 commits into
masterfrom
fix/staging-candidate-integrated-qualification

Conversation

@anth-volk

Copy link
Copy Markdown
Collaborator

Fixes #3869

Summary

  • run the tagged staging candidate integration suite in the deployment job immediately after readiness succeeds
  • remove the separate integration job and its additional runner wait
  • preserve the existing exact-candidate URL, staging database secret, live simulation checks, and promotion dependencies

Failure reproduced

Validation

  • actionlint .github/workflows/push.yml
  • uv run --frozen pytest tests/unit/test_cloud_run_deploy_scripts.py -q (112 passed)
  • uv run --frozen ruff format --check tests/unit/test_cloud_run_deploy_scripts.py
  • uv run --frozen ruff check tests/unit/test_cloud_run_deploy_scripts.py
  • parsed .github/workflows/push.yml with PyYAML

No environment variables, secrets, service accounts, infrastructure, traffic settings, or API contracts are added or changed.

@anth-volk
anth-volk marked this pull request as ready for review October 7, 2026 19:17
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.56%. Comparing base (f03e630) to head (ddedbd0).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3870       +/-   ##
===========================================
+ Coverage   45.22%   87.56%   +42.33%     
===========================================
  Files         183      198       +15     
  Lines       11073    12211     +1138     
  Branches     1905     2159      +254     
===========================================
+ Hits         5008    10692     +5684     
+ Misses       5644      922     -4722     
- Partials      421      597      +176     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk
anth-volk merged commit 9bf0ae6 into master Oct 8, 2026
14 checks passed
@anth-volk
anth-volk deleted the fix/staging-candidate-integrated-qualification branch October 8, 2026 17:45

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep staging candidate integration tests on the deployment runner

1 participant