Repository navigation
Resolve the CI-script exceptions outside the deploy pipelines - #762
Merged
Merged
Conversation
anth-volk
added this pull request to stack #755
October 12, 2026 20:30
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
from
October 13, 2026 16:56
77b5ce0 to
d37053f
Compare
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
4 times, most recently
from
October 14, 2026 15:56
49047a4 to
0754e3d
Compare
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
3 times, most recently
from
October 14, 2026 19:46
c1a4b0b to
4ff84e1
Compare
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
from
October 14, 2026 20:04
4ff84e1 to
28b92f5
Compare
Print the local-run hint with escaped double quotes instead of single quotes (SC2016). The message is byte-identical; a test now asserts it. With its only baseline entry gone, sim.ci.shell-scripts-pass-shellcheck is enforced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run the three update-dependencies.yml scripts with fake gh, git and date commands first on PATH and assert on every call and $GITHUB_OUTPUT value, covering the open-PR and new-branch paths and their failures. A small support module installs fakes that record their exact arguments. update-policyengine-package.sh was already exercised through a fixture module; name it in the executor test that checks the workflow runs it. With its baseline empty, sim.ci.workflow-scripts-tested is enforced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Test matrix: run uv sync and pytest with the step's working-directory instead of cd. - Lint: check every src directory with one ruff format --check call; it checks the same files as the loop and reports every unformatted directory instead of stopping at the first. - Integration: start and wait for the local services with a tested start-local-services.sh, and split installing the integration test dependencies from running the tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
publish-clients.yml now versions and builds the simulation API client with a tested build-simulation-api-client.sh, reading the run number from the step's env: instead of interpolating it into shell. pr-image-smoke.yml drops the redundant chmod: modal-image-smoke.sh is committed executable, and a test now checks that every script a workflow runs directly is executable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sync scripts/rules with policyengine-api. Once a CI-script rule is enforced it has no baseline, so its findings were reported as [registry]; fall back to the rule whose id ends in the check's name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
force-pushed
the
ci-scripts-exceptions
branch
from
October 14, 2026 20:14
28b92f5 to
54fb7e8
Compare
anth-volk
marked this pull request as ready for review
October 14, 2026 21:43
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #760
Same-Repository Draft PR Check
PolicyEngine/policyengine-sim-api, not a personal fork.Summary
Phase 1 step 1.7, part 1. Stacked on #757; the deploy-pipeline part is the next PR in the stack.
pr.yml:working-directoryinstead ofcd.uv run ruff format --check projects/*/src libs/*/src. It checks the same 131 files and now reports every unformatted directory, not just the first.start-local-services.sh. As before, it exits 0 even if the services never come up; a test pins that.pr-image-smoke.yml: one line. Thechmodwas redundant, because the script is committed executable; a new test checks that every directly-run workflow script is executable.publish-clients.yml: a new tested script,build-simulation-api-client.sh, takesRUN_NUMBERfromenv:.gh,gitanddate, andupdate-policyengine-package.shis now named in an executor test.modal-precompute.sh: fixes SC2016 with byte-identical output, which a new assertion checks.ci-scriptsattribution fix as the API.scripts/rules/is byte-identical.Testing
test_modal_scripts.pyplus the package-update tests: 74 pass.guard --base-ref rules-followupspasses. Rules tool unittest: 75 pass.uv.lockfiles are unchanged.🤖 Generated with Claude Code