Repository navigation
Conversation
|
UK hub (Claude session, for Max): this draft passes CI and is mergeable, and Max asked on 22 Oct to clear the UK PR backlog before the Budget. I've queued an independent review of this PR with seven of your other Housing Benefit drafts, and will mark it ready and land it through the merge queue if the review approves at this head. @anth-volk, reply here if you'd like it held or you're still changing it. |
# Conflicts: # policyengine_uk/parameters/gov/dwp/housing_benefit/non_dep_deduction/amount.yaml
|
UK hub hand-off for Max; Anthony Volk's draft and original commits are retained. Head: Change: corrected all twelve 2018 scale dates to 2 April, the weekly-rent commencement in SI 2018/281 articles 1(2)(h), 23(3) and 24(3). Other rent periods start on 1 April; both precede the model's 30 April sample. Raw and processed scale tests plus a shared HB/CTR YAML fixture pin the £793 annual deduction for £100/week income, preventing the £23.40 shortfall. Tests: 292 passed with foreground Open items: hub independent review and CI at this head; existing |
Aggregate impact on certified data: passBase Checks: 0 broken by this change, 1 failing on both sides, 0 fixed. Moves flagged for review: 0 (thresholds in Notes
Moves flagged for reviewNone. Spending by benefit and service
Caseloads
Standard reform costings (change in gov_balance)
Standard reforms: change in each reform's target
Household net income by decileNo household's net income changes in any year. No change in any year: receipts by tax head; government balance, each component counted once; model totals; household income totals; population; poverty rates; people in poverty; inequality; mean household net income in each side's own deciles. Checks failing on both base and head (1)
Counted-once checkEach of 84 components was raised by £1 per unit in 2026-27, and every head of its totals was read household by household: its own head must rise by exactly £1, no other tax head may move, no other benefit may rise, and the model's own total must move by what its heads moved. A head that breaks a rule is measured again twice: with every other head held at its baseline value, and with every other head held at its value after the first £1 while the component rises again. It fails where either still shows the response. 0 failed; 0 were skipped. Provenance
Dataset: Receipts by tax head: head levels
Spending by benefit and service: head levels
Caseloads: head levels
Government balance, each component counted once: head levels
Model totals: head levels
Household income totals: head levels
Population: head levels
Poverty rates: head levels
People in poverty: head levels
Inequality: head levels
Mean household net income in each side's own deciles: head levels
Standard reform costings (change in gov_balance): head levels
Standard reforms: change in each reform's target: head levels
|
With five shards the Python test jobs took 45 to 59 minutes on 23 October. In the merge-queue run for #2213 (run 40034703741), shard 4/5's tests all passed in 59m32s, and the 60-minute limit then cancelled the job during its Codecov upload. The queue took #2213 out and rebuilt every group behind it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #2212
Adds the enacted 2015–2017 Housing Benefit non-dependant deduction thresholds and amounts, with the original cell references to 2015 article 18(3), 2016 regulation 5, and 2017 article 22(4).
Corrects all twelve 2018 cells to 2 April 2018, the weekly-rent commencement in SI 2018/281 articles 1(2)(h), 23(3), and 24(3). Other rent periods commence on 1 April; both precede the model's 30 April fiscal-year sample. The processed 2018–19 deduction for an eligible non-dependant earning £100/week is £793/year. Leaving the June dates after adding historical values instead selects £769.60, potentially overpaying HB and shared-scale CTR by £23.40.
Merged
origin/mainata45baf5e490928db20fda96eb845214853fe8068with a merge commit, preserving all later rates and uprating metadata while retaining Anthony Volk's historical cells and references. Separate eligibility/banding work is tracked in #2007 and within-unit coverage in #2017.Validation in the frozen worktree environment (Python 3.13.9, core 3.33.2):
pytest -n 2: 292 passed, comprising 6 Python history/processing tests and 286 YAML cases across the full HB family directory plus the HB pension-age means-test and Pension Credit HB files. No failures, errors, or skips.uvx ruff==0.17.0 format --check .: all 1,957 files formatted;ruff check .,uv pip check,git diff --check, and the CI fix-evidence checker passed.The hub will commission independent review at the pushed head. Axiom parity remains an open hand-off item.
Reproducer: policyengine_uk/tests/test_housing_benefit_non_dep_history.py::test_processed_2018_scale_uses_april_commencement
Reproducer: policyengine_uk/tests/policy/baseline/finance/benefit/family/housing_benefit/non_dep_deduction/household_benefits_individual_non_dep_deduction.yaml::The 2018 fiscal year uses the April non-dependant deduction in HB and CTR
axiom: needed