Repository navigation
Document domestic and overseas carbon flows - #2482
Conversation
vahid-ahmadi
left a comment
There was a problem hiding this comment.
Fine once the two source points are fixed.
@juaristi22, the page now matches the code. I checked the formula block against carbon_tax.py, the intensity fallback against carbon.py, and the two denominators against shareholding.py. All three agree. The old table's claims about border adjustment and taxing owners directly have gone, which is right, because no formula implements them.
- should:
carbon-tax.ipynb, first cell, table row "Outside the UK / UK households". It says that any overseas production in the intensity inputs "remains combined" and that the formulas "cannot identify its share". We do know more than that. The sector emissions inparameters/household/consumption/carbon/emissions.yamlcome from DEFRA's "UK's carbon footprint" statistics. That series is consumption-based, so it includes emissions embedded in imports. Please say so plainly: imported emissions are in the footprint, but with no UK/overseas split. That is the direct answer to the second bullet of #478. - should:
carbon-tax.ipynb, the appendix text says the chart uses "fixed illustrative intensities". The 12 numbers in the code cell are exactly the 2019-01-01 values inparameters/household/consumption/carbon/intensity.yaml(for example 7.7e-05 for alcohol and tobacco, 0.0012 for housing, water and electricity). Please label them as the 2019 DEFRA fallback intensities, not as illustrative. Otherwise a reader may think they were made up. - nit:
myst.yml:39puts a contributed-reform notebook first under "Programmes", ahead of all thegov/*pages. That is a little odd for a hypothetical tax. Placing it after the pattern line would keep the statutory programmes first. This is your call. - nit: #2187 also edits
myst.yml, two lines above this hunk. I checked withgit merge-treeand the two branches merge cleanly.
What I checked
- Read the full diff, the PR body and #478. Compared the new text with
carbon_tax.py,carbon.py,shareholding.pyand the five carbon parameter files. - Confirmed that only the first notebook cell changes. The code cell and its outputs are unchanged.
- No law to check: this changes documentation only.
- Hosted CI: 5 checks pass and 4 are skipped, as usual for a docs-only PR. I did not build the docs locally.
- The changelog fragment is
changed. The Reproducer and axiom lines aren/awith reasons, and the Fix evidence check passes.
🤖 Generated with Claude Code
b1d06c5 to
00b8e9b
Compare
|
Addressed both requested documentation fixes in Schema, source/value preservation, formatting, lint, Fix evidence and offline page-render checks pass. Independent CODE and POLICY verification found no findings or material gaps in this scope. The full local MyST build required an npm installation, which remained blocked; the full-site documentation check still needs to pass on this head in hosted CI. No numerical calculation, new empirical estimate or parity claim is added. |
vahid-ahmadi
left a comment
There was a problem hiding this comment.
Approving. Both source points are fixed.
@juaristi22, thanks. I reviewed the change since my last review at b1d06c57e. The branch was rebased onto main, so the commit range pulls in many main commits. The PR's own changes are still only the changelog fragment, the first notebook cell and the myst.yml line, and I compared those three files directly.
Earlier points
- should (imported emissions): Fixed. The "Outside the UK / UK households" row now says DEFRA's consumption-based footprint includes emissions embedded in imports, with no UK/overseas split. The link is the same page that
emissions.yamlcites, and it resolves. - should (illustrative intensities): Fixed. The appendix is now headed "2019 DEFRA fallback intensities" and links
intensity.yaml. I checked the 12 values in the code cell again: they match the 2019-01-01 entries exactly. - nit (contrib notebook first under "Programmes"): not changed. That was your call, and it is fine as it is.
- nit (#2187 also edits
myst.yml): no longer relevant. #2187 merged on 18 Oct, and thevat-coverage.mdline now comes from main. The PR merges cleanly.
New findings: none.
What I checked
- The diff of the three PR files from
b1d06c57eto00b8e9bad. The code cell and its outputs are unchanged. - The new wording against
emissions.yaml,intensity.yamland the DEFRA statistics page. - The PR body still has the
Reproducer: n/aandaxiom: n/alines with reasons. The fragment ischanged, and the Fix evidence check passes. - Hosted CI on
00b8e9bad: 5 checks pass and 4 are skipped, the same as last round. "Test documentation builds" passes. The full "Documentation build" job is skipped for this PR, so it has not run on this head. I did not build the docs locally.
🤖 Generated with Claude Code
Fixes #478.
The existing carbon-tax page mixed production location with owner residence and described tax and border-adjustment mechanisms the household formulas do not implement. It now explains the four UK/overseas production and consumption combinations, the consumer/shareholder allocation, and which flows remain undifferentiated or unrepresented. The existing notebook is linked in the documentation navigation; its appendix identifies the twelve fixed values as the 2019 DEFRA fallback intensities. The consumption-based footprint explanation explicitly includes imported emissions and retains the model's missing production-origin split.
Only the first Markdown cell, navigation and a changelog fragment change. All notebook code, saved outputs, and cell/notebook metadata are unchanged. No variable, parameter, dataset or numerical result changes.
Initial validation:
make formatpassed (1,740 Python files unchanged); notebook schema, unchanged code/output/metadata, navigation and local source-link checks passed;make documentationpassed in 12.24 seconds with notebook execution off, and the rendered carbon-tax page contains the table and incidence explanation. The first sandbox build could not resolve the template host; the network-enabled rerun passed. No model tests or private microsimulation were needed for this documentation-only change.Reproducer: n/a: documentation and navigation only; model source and dependencies are unchanged.
axiom: n/a: documentation of existing model mechanics; no statutory calculation change or encoded-parity claim.
Review follow-up: notebook schema, unchanged code/output/metadata, source links and the twelve 2019 fallback values passed static validation. No notebook or model calculations were executed. Integrated documentation-build results will be recorded in the review reply.